You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/11 10:09:25 UTC
[GitHub] [echarts] behroozbc opened a new pull request #14915: add string type to height for percent
behroozbc opened a new pull request #14915:
URL: https://github.com/apache/echarts/pull/14915
https://github.com/apache/echarts/issues/14914
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
add type of string to height in TextCommonOption
### Fixed issues
https://github.com/apache/echarts/issues/14914
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
height type is only number and cant accept percent
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
I add string to fix this bug
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] behroozbc closed pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
behroozbc closed pull request #14915:
URL: https://github.com/apache/echarts/pull/14915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14915:
URL: https://github.com/apache/echarts/pull/14915#issuecomment-839496796
@behroozbc Hi, text height in echarts doesn't support percentage value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] behroozbc edited a comment on pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
behroozbc edited a comment on pull request #14915:
URL: https://github.com/apache/echarts/pull/14915#issuecomment-839498599
@pissang hi , but in this [example](https://echarts.apache.org/examples/en/editor.html?c=gauge-temperature) used
example must change and fix ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14915:
URL: https://github.com/apache/echarts/pull/14915#issuecomment-839585088
@behroozbc It's only supported in the gauge series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] behroozbc commented on pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
behroozbc commented on pull request #14915:
URL: https://github.com/apache/echarts/pull/14915#issuecomment-840320247
@pissang but echartOption dont support that
I found a few problem in example of echarts how can I submit ?
example have repository ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] behroozbc commented on pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
behroozbc commented on pull request #14915:
URL: https://github.com/apache/echarts/pull/14915#issuecomment-839498599
@pissang hi , but in this (example)[https://echarts.apache.org/examples/en/editor.html?c=gauge-temperature] used
example must change and fix ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14915: add string type to height for percent
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14915:
URL: https://github.com/apache/echarts/pull/14915#issuecomment-838206509
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org