[GitHub] [cloudstack] vladimirpetrov commented on pull request #4503: Specify IP for VR in shared networks

[GitBox <gi...@apache.org>]

vladimirpetrov commented on pull request #4503:
URL: https://github.com/apache/cloudstack/pull/4503#issuecomment-764525956


   LGTM!
   
   Tested:
   - creating shared network with predefined VR IP (using UI and API), then deploying a VM using the same network
   - deploying a VM on a shared network with predefined VR IP using the same IP as a VM's - expected error message is shown
   - creating shared network with a network offering without services - the field for VR IP is hidden as expected
   - restarting a shared network with predefined VR IP (with and without cleanup) does not affect the predefined IP address of the router
   - attempting to create a non-shared network with predefined VR IP using the API fails with a proper error message
   - creating a shared network without defining VR IP address is possible - the field is not mandatory
   - VR IP field does not allow incorrect values


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org