You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by sijie <gi...@git.apache.org> on 2017/05/25 02:56:12 UTC
[GitHub] bookkeeper pull request #160: BOOKKEEPER-1073: Several stats provider relate...
GitHub user sijie opened a pull request:
https://github.com/apache/bookkeeper/pull/160
BOOKKEEPER-1073: Several stats provider related changes.
- add finagle stats provider
- provide the ability to remove gauge and scopes
- update jetty versions for twitter-sciences stats provider
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/bookkeeper add_channel_writer_timer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 88a0cc02789165f5220086244378007189f382d5
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-25T02:07:27Z
Add twitter-finagle-provider
commit fba0e92f5b586aa5885dfce072df3913b1ef3e92
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-25T02:52:01Z
Resolve the conflicts with merges
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #160: BOOKKEEPER-1073: Several stats provider related chang...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/160
@sijie can you rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #160: BOOKKEEPER-1073: Several stats provider related chang...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/160
+1 still great.
I am going to merge, or @sijie are you merging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #160: BOOKKEEPER-1073: Several stats provider related chang...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/160
Changes were made from multiple folks at Twitter. I just ported these changes back to the community.
@yzang @leighst
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #160: BOOKKEEPER-1073: Several stats provider related chang...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/160
@eolivelli feel free to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #160: BOOKKEEPER-1073: Several stats provider relate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---