You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "JKrehling (via GitHub)" <gi...@apache.org> on 2024/08/08 18:34:41 UTC
[PR] Setting least permissive securitycontexts possible [airflow]
JKrehling opened a new pull request, #41341:
URL: https://github.com/apache/airflow/pull/41341
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
Added emptyDir volumes for volumes being utilized by airflow and least permissive securityContexts by default.
closes: #35350
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41341:
URL: https://github.com/apache/airflow/pull/41341#issuecomment-2560459466
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #41341:
URL: https://github.com/apache/airflow/pull/41341#issuecomment-2276429337
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "JKrehling (via GitHub)" <gi...@apache.org>.
JKrehling commented on code in PR #41341:
URL: https://github.com/apache/airflow/pull/41341#discussion_r1826100449
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -229,6 +231,10 @@ spec:
{{- if .Values.dagProcessor.extraContainers }}
{{- tpl (toYaml .Values.dagProcessor.extraContainers) . | nindent 8 }}
{{- end }}
+ - name: tmp
+ mountPath: /tmp
+ - name: opt
+ mountPath: /opt/airflow
Review Comment:
Just pushed the change you suggested 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "DjVinnii (via GitHub)" <gi...@apache.org>.
DjVinnii commented on code in PR #41341:
URL: https://github.com/apache/airflow/pull/41341#discussion_r1816595058
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -229,6 +231,10 @@ spec:
{{- if .Values.dagProcessor.extraContainers }}
{{- tpl (toYaml .Values.dagProcessor.extraContainers) . | nindent 8 }}
{{- end }}
+ - name: tmp
+ mountPath: /tmp
+ - name: opt
+ mountPath: /opt/airflow
Review Comment:
Doesn't it make more sense to define the `/opt/airflow` mountPath based on the `airflowHome` value and have the name more generic like `airflow-home`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41341: Setting least permissive securitycontexts possible
URL: https://github.com/apache/airflow/pull/41341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "JKrehling (via GitHub)" <gi...@apache.org>.
JKrehling commented on code in PR #41341:
URL: https://github.com/apache/airflow/pull/41341#discussion_r1821356141
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -229,6 +231,10 @@ spec:
{{- if .Values.dagProcessor.extraContainers }}
{{- tpl (toYaml .Values.dagProcessor.extraContainers) . | nindent 8 }}
{{- end }}
+ - name: tmp
+ mountPath: /tmp
+ - name: opt
+ mountPath: /opt/airflow
Review Comment:
yeah that probably makes more sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "JKrehling (via GitHub)" <gi...@apache.org>.
JKrehling commented on PR #41341:
URL: https://github.com/apache/airflow/pull/41341#issuecomment-2291400466
The only thing that doesn't have readonlyfileystem is git-sync because it requires writing to /etc/passwd.
I could mount /etc/passwd as a configmap to support it but since its just an init container I don't think it's as important to use hardened scc by default.
I am curious about redis.
I don't know how prevalently used it is but it might be better to pull the bitnami chart as a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "JKrehling (via GitHub)" <gi...@apache.org>.
JKrehling commented on code in PR #41341:
URL: https://github.com/apache/airflow/pull/41341#discussion_r1821362746
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -229,6 +231,10 @@ spec:
{{- if .Values.dagProcessor.extraContainers }}
{{- tpl (toYaml .Values.dagProcessor.extraContainers) . | nindent 8 }}
{{- end }}
+ - name: tmp
+ mountPath: /tmp
+ - name: opt
+ mountPath: /opt/airflow
Review Comment:
So this would be changed in the dag-processor, flower, scheduler, webserver, worker deployments.
There are some yaml tamplates though where /opt/airflow is hardcoded already so I believe I was following that. For example if you look in basic_template.yaml
Im not certain if all files in the "dag-processor, flower, scheduler, webserver, worker deployments" pods are only created in the airflow_home directory, or if both should be mounted, /opt/airflow and whatever airflowhome is set to.
Let me know if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Setting least permissive securitycontexts possible [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41341:
URL: https://github.com/apache/airflow/pull/41341#issuecomment-2409047498
Generally rebaase and making sure all tests pass. I rebased it. As a new contributor, your workflows need to be approved so any time you rebase and fix you need to ask here (just make a comment without mentioning anyone) - to approve and run your workflow.
Once first pr of your will be merged, the workflows will run automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org