You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:52:50 UTC
Review Request 61284: Made `libprocess` use default linking.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61284/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
The static/shared specifier and the PIC property were redundant.
Diffs
-----
3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d
Diff: https://reviews.apache.org/r/61284/diff/1/
Testing
-------
Actually, this whole file was rewritten later, with this change included. Could be squashed.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61284: Made `libprocess` use default linking.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61284/#review182342
-----------------------------------------------------------
Ship it!
[Tentative "Ship It!" as I review this entire chain.]
Because I like to add context to commit messages, I'm going to extend your commit message to mention why these things are redundant:
(: the `BUILD_SHARED_LIBS` and `CMAKE_POSITION_INDEPENDENT_CODE` global variables :)
- Joseph Wu
On Aug. 1, 2017, 5:52 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61284/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:52 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The static/shared specifier and the PIC property were redundant.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d
>
>
> Diff: https://reviews.apache.org/r/61284/diff/1/
>
>
> Testing
> -------
>
> Actually, this whole file was rewritten later, with this change included. Could be squashed.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>