You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/07/24 17:46:15 UTC
[GitHub] [nuttx] raiden00pl opened a new pull request, #9883: cmake: enable more cmake builds
raiden00pl opened a new pull request, #9883:
URL: https://github.com/apache/nuttx/pull/9883
## Summary
cmake: enable more cmake builds
related to https://github.com/apache/nuttx/pull/9865
## Impact
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9883: cmake: enable more cmake builds
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9883:
URL: https://github.com/apache/nuttx/pull/9883#discussion_r1272580704
##########
tools/ci/testlist/arm-05.dat:
##########
@@ -26,15 +26,15 @@ CMake,nrf52840-dk:buttons
CMake,nrf52840-dk:cdcacm
# CMake,nrf52840-dk:composite
CMake,nrf52840-dk:highpri
-# CMake,nrf52840-dk:mcuboot_app
-# CMake,nrf52840-dk:mcuboot_loader
+CMake,nrf52840-dk:mcuboot_app
+CMake,nrf52840-dk:mcuboot_loader
CMake,nrf52840-dk:nsh
CMake,nrf52840-dk:ostest_tickless
CMake,nrf52840-dk:pwm
CMake,nrf52840-dk:qspi
-#CMake,nrf52840-dk:rndis
-# CMake,nrf52840-dk:sdc
-# CMake,nrf52840-dk:sdc_nimble
+# CMake,nrf52840-dk:rndis
Review Comment:
can we remove all comment like nrf52840-dk:rndis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9883: cmake: enable more cmake builds
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #9883:
URL: https://github.com/apache/nuttx/pull/9883#discussion_r1272916149
##########
tools/ci/testlist/arm-05.dat:
##########
@@ -26,15 +26,15 @@ CMake,nrf52840-dk:buttons
CMake,nrf52840-dk:cdcacm
# CMake,nrf52840-dk:composite
CMake,nrf52840-dk:highpri
-# CMake,nrf52840-dk:mcuboot_app
-# CMake,nrf52840-dk:mcuboot_loader
+CMake,nrf52840-dk:mcuboot_app
+CMake,nrf52840-dk:mcuboot_loader
CMake,nrf52840-dk:nsh
CMake,nrf52840-dk:ostest_tickless
CMake,nrf52840-dk:pwm
CMake,nrf52840-dk:qspi
-#CMake,nrf52840-dk:rndis
-# CMake,nrf52840-dk:sdc
-# CMake,nrf52840-dk:sdc_nimble
+# CMake,nrf52840-dk:rndis
Review Comment:
Hi, @raiden00pl have you doing cmake porting of argtable3, if not in your plan, I will complete argtable3 porting soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9883: cmake: enable more cmake builds
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9883:
URL: https://github.com/apache/nuttx/pull/9883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9883: cmake: enable more cmake builds
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #9883:
URL: https://github.com/apache/nuttx/pull/9883#discussion_r1272916149
##########
tools/ci/testlist/arm-05.dat:
##########
@@ -26,15 +26,15 @@ CMake,nrf52840-dk:buttons
CMake,nrf52840-dk:cdcacm
# CMake,nrf52840-dk:composite
CMake,nrf52840-dk:highpri
-# CMake,nrf52840-dk:mcuboot_app
-# CMake,nrf52840-dk:mcuboot_loader
+CMake,nrf52840-dk:mcuboot_app
+CMake,nrf52840-dk:mcuboot_loader
CMake,nrf52840-dk:nsh
CMake,nrf52840-dk:ostest_tickless
CMake,nrf52840-dk:pwm
CMake,nrf52840-dk:qspi
-#CMake,nrf52840-dk:rndis
-# CMake,nrf52840-dk:sdc
-# CMake,nrf52840-dk:sdc_nimble
+# CMake,nrf52840-dk:rndis
Review Comment:
Hi, @raiden00pl have you doing cmake porting of argtable3 ? if not in your plan, I will complete argtable3 porting soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9883: cmake: enable more cmake builds
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #9883:
URL: https://github.com/apache/nuttx/pull/9883#discussion_r1272967157
##########
tools/ci/testlist/arm-05.dat:
##########
@@ -26,15 +26,15 @@ CMake,nrf52840-dk:buttons
CMake,nrf52840-dk:cdcacm
# CMake,nrf52840-dk:composite
CMake,nrf52840-dk:highpri
-# CMake,nrf52840-dk:mcuboot_app
-# CMake,nrf52840-dk:mcuboot_loader
+CMake,nrf52840-dk:mcuboot_app
+CMake,nrf52840-dk:mcuboot_loader
CMake,nrf52840-dk:nsh
CMake,nrf52840-dk:ostest_tickless
CMake,nrf52840-dk:pwm
CMake,nrf52840-dk:qspi
-#CMake,nrf52840-dk:rndis
-# CMake,nrf52840-dk:sdc
-# CMake,nrf52840-dk:sdc_nimble
+# CMake,nrf52840-dk:rndis
Review Comment:
@raiden00pl Please review PR https://github.com/apache/nuttx-apps/pull/1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on a diff in pull request #9883: cmake: enable more cmake builds
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #9883:
URL: https://github.com/apache/nuttx/pull/9883#discussion_r1273019167
##########
tools/ci/testlist/arm-05.dat:
##########
@@ -26,15 +26,15 @@ CMake,nrf52840-dk:buttons
CMake,nrf52840-dk:cdcacm
# CMake,nrf52840-dk:composite
CMake,nrf52840-dk:highpri
-# CMake,nrf52840-dk:mcuboot_app
-# CMake,nrf52840-dk:mcuboot_loader
+CMake,nrf52840-dk:mcuboot_app
+CMake,nrf52840-dk:mcuboot_loader
CMake,nrf52840-dk:nsh
CMake,nrf52840-dk:ostest_tickless
CMake,nrf52840-dk:pwm
CMake,nrf52840-dk:qspi
-#CMake,nrf52840-dk:rndis
-# CMake,nrf52840-dk:sdc
-# CMake,nrf52840-dk:sdc_nimble
+# CMake,nrf52840-dk:rndis
Review Comment:
@anchao great, I'll enable rndis configurations after merging apache/nuttx-apps#1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on a diff in pull request #9883: cmake: enable more cmake builds
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #9883:
URL: https://github.com/apache/nuttx/pull/9883#discussion_r1272586999
##########
tools/ci/testlist/arm-05.dat:
##########
@@ -26,15 +26,15 @@ CMake,nrf52840-dk:buttons
CMake,nrf52840-dk:cdcacm
# CMake,nrf52840-dk:composite
CMake,nrf52840-dk:highpri
-# CMake,nrf52840-dk:mcuboot_app
-# CMake,nrf52840-dk:mcuboot_loader
+CMake,nrf52840-dk:mcuboot_app
+CMake,nrf52840-dk:mcuboot_loader
CMake,nrf52840-dk:nsh
CMake,nrf52840-dk:ostest_tickless
CMake,nrf52840-dk:pwm
CMake,nrf52840-dk:qspi
-#CMake,nrf52840-dk:rndis
-# CMake,nrf52840-dk:sdc
-# CMake,nrf52840-dk:sdc_nimble
+# CMake,nrf52840-dk:rndis
Review Comment:
rndis and composite configurations need `argtable3` which is not yet ported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org