You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/10 14:42:37 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5710: boards/arm/samv7: rework linker script usage logic to allow custom linker scripts
pkarashchenko opened a new pull request #5710:
URL: https://github.com/apache/incubator-nuttx/pull/5710
## Summary
This PR breaks SAMV7 dependency on `BOARD_COMMON_DIR` for linker script generation logic:
- Allow to locate linker script templates at specific board level instead of board common level
- Generate kernel build linker script from a template
- Move make rules from common to per-board `Make.defs`
## Impact
Introduce an option for custom boards to have custom board based linker scripts
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5710: boards/arm/samv7: rework linker script usage logic to allow custom linker scripts
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5710:
URL: https://github.com/apache/incubator-nuttx/pull/5710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5710: boards/arm/samv7: rework linker script usage logic to allow custom linker scripts
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5710:
URL: https://github.com/apache/incubator-nuttx/pull/5710#discussion_r823950687
##########
File path: boards/arm/samv7/common/scripts/kernel-space.ld
##########
@@ -18,7 +18,7 @@
*
****************************************************************************/
-/* NOTE: This depends on the memory.ld script having been included prior to
+/* NOTE: This depends on the memory.ld.template script having been included prior to
Review comment:
move "prior to" to next line
##########
File path: boards/arm/samv7/common/scripts/user-space.ld
##########
@@ -18,7 +18,7 @@
*
****************************************************************************/
-/* NOTE: This depends on the memory.ld script having been included prior to
+/* NOTE: This depends on the memory.ld.template script having been included prior to
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5710: boards/arm/samv7: rework linker script usage logic to allow custom linker scripts
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5710:
URL: https://github.com/apache/incubator-nuttx/pull/5710#discussion_r824067897
##########
File path: boards/arm/samv7/common/scripts/kernel-space.ld
##########
@@ -18,7 +18,7 @@
*
****************************************************************************/
-/* NOTE: This depends on the memory.ld script having been included prior to
+/* NOTE: This depends on the memory.ld.template script having been included prior to
Review comment:
done
##########
File path: boards/arm/samv7/common/scripts/user-space.ld
##########
@@ -18,7 +18,7 @@
*
****************************************************************************/
-/* NOTE: This depends on the memory.ld script having been included prior to
+/* NOTE: This depends on the memory.ld.template script having been included prior to
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org