You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2010/10/23 12:26:19 UTC
[jira] Resolved: (SHINDIG-1452) Allow FeedProcessor to be swapped
out via Guice injection
[ https://issues.apache.org/jira/browse/SHINDIG-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1452.
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Patch (modified) applied. Thanks!
> Allow FeedProcessor to be swapped out via Guice injection
> ---------------------------------------------------------
>
> Key: SHINDIG-1452
> URL: https://issues.apache.org/jira/browse/SHINDIG-1452
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0
> Reporter: Bill Wolcken
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 0001-Convert-FeedProcessor-to-an-interface-and-allow-for-.patch
>
>
> Many classes within Shindig can be easily swapped out and replaced by container implementations via Guice injection. FeedProcessor is not one of them, since HttpRequestHandler and MakeRequestHandler directly instantiate instances of FeedProcessor. To allow FeedProcessor to be swapped out, FeedProcessor should be replaced with an interface/implementation pair, and HttpRequestHandler and MakeRequestHandler should accept a FeedProcessor Provider as a constructor argument.
> I have made the above described changes against the 2.0.x baseline in the Shindig project fork used by Eureka Streams. I will attempt to upload and attach a git patch file for the changes. (The fork also had prior changes to FeedProcessor to support feed images, so that additional feature comes along too.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.