You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2016/03/13 17:43:48 UTC
Add .map to the list of allowed file extensions in SecurePackageResourceGuard
Hi,
At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user requested
to add .map to SPRG.
I think I have added .map and then removed it once but now I cannot find it
in Git history...
.map is used to map generated and/or minified js/css resources to their
original version, so one can debug easily.
E.g. a .css file generated by LESS/SASS.
The browser makes a call to get the .map file only when DevTools are used.
Do you see any issues of adding .map to the whitelist ?
If someone doesn't want to serve her non-minified version of some important
.js file then (s)he should not add /*sourceMapUrl=...*/ in first place in
the content of .min.js.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
Re: Add .map to the list of allowed file extensions in SecurePackageResourceGuard
Posted by Martin Grigorov <mg...@apache.org>.
https://issues.apache.org/jira/browse/WICKET-6122
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Mar 14, 2016 at 8:10 AM, Maxim Solodovnik <so...@gmail.com>
wrote:
> Thanks :)
>
> On Mon, Mar 14, 2016 at 1:09 PM, Sebastien <se...@gmail.com> wrote:
>
> > Hi Maxim,
> >
> > On Mar 14, 2016 02:49, "Maxim Solodovnik" <so...@gmail.com> wrote:
> > >
> > > +1, I recently notice error from kendo-ui regarding *.map files
> >
> > Me too, I will have a look. Maybe I missed some .map files...
> >
> > >
> > > WBR, Maxim
> > > (from mobile, sorry for the typos)
> > > On Mar 14, 2016 02:12, "Sebastien" <se...@gmail.com> wrote:
> > >
> > > > > I think I have added .map and then removed it once but now I cannot
> > find
> > > > it in Git history...
> > > >
> > > > Maybe you remembered a wicket-kendo-ui commit?
> > > >
> > > >
> >
> >
> https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-kendo-ui/src/main/java/com/googlecode/wicket/kendo/ui/Initializer.java#L45
> > > >
> > > > I'm definitely +1 to add it.
> > > >
> > > > Thanks & best regards,
> > > > Sebastien
> > > >
> > > >
> > > >
> > > >
> > > > On Sun, Mar 13, 2016 at 9:08 PM, Sven Meier <sv...@meiers.net> wrote:
> > > >
> > > > > I'm fine with .map on the whitelist.
> > > > >
> > > > > Regards
> > > > > Sven
> > > > >
> > > > >
> > > > > On 13.03.2016 17:43, Martin Grigorov wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user
> > > > >> requested
> > > > >> to add .map to SPRG.
> > > > >> I think I have added .map and then removed it once but now I
> cannot
> > find
> > > > >> it
> > > > >> in Git history...
> > > > >>
> > > > >> .map is used to map generated and/or minified js/css resources to
> > their
> > > > >> original version, so one can debug easily.
> > > > >> E.g. a .css file generated by LESS/SASS.
> > > > >>
> > > > >> The browser makes a call to get the .map file only when DevTools
> are
> > > > used.
> > > > >>
> > > > >> Do you see any issues of adding .map to the whitelist ?
> > > > >> If someone doesn't want to serve her non-minified version of some
> > > > >> important
> > > > >> .js file then (s)he should not add /*sourceMapUrl=...*/ in first
> > place
> > > > in
> > > > >> the content of .min.js.
> > > > >>
> > > > >>
> > > > >> Martin Grigorov
> > > > >> Wicket Training and Consulting
> > > > >> https://twitter.com/mtgrigorov
> > > > >>
> > > > >>
> > > > >
> > > >
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Add .map to the list of allowed file extensions in SecurePackageResourceGuard
Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks :)
On Mon, Mar 14, 2016 at 1:09 PM, Sebastien <se...@gmail.com> wrote:
> Hi Maxim,
>
> On Mar 14, 2016 02:49, "Maxim Solodovnik" <so...@gmail.com> wrote:
> >
> > +1, I recently notice error from kendo-ui regarding *.map files
>
> Me too, I will have a look. Maybe I missed some .map files...
>
> >
> > WBR, Maxim
> > (from mobile, sorry for the typos)
> > On Mar 14, 2016 02:12, "Sebastien" <se...@gmail.com> wrote:
> >
> > > > I think I have added .map and then removed it once but now I cannot
> find
> > > it in Git history...
> > >
> > > Maybe you remembered a wicket-kendo-ui commit?
> > >
> > >
>
> https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-kendo-ui/src/main/java/com/googlecode/wicket/kendo/ui/Initializer.java#L45
> > >
> > > I'm definitely +1 to add it.
> > >
> > > Thanks & best regards,
> > > Sebastien
> > >
> > >
> > >
> > >
> > > On Sun, Mar 13, 2016 at 9:08 PM, Sven Meier <sv...@meiers.net> wrote:
> > >
> > > > I'm fine with .map on the whitelist.
> > > >
> > > > Regards
> > > > Sven
> > > >
> > > >
> > > > On 13.03.2016 17:43, Martin Grigorov wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user
> > > >> requested
> > > >> to add .map to SPRG.
> > > >> I think I have added .map and then removed it once but now I cannot
> find
> > > >> it
> > > >> in Git history...
> > > >>
> > > >> .map is used to map generated and/or minified js/css resources to
> their
> > > >> original version, so one can debug easily.
> > > >> E.g. a .css file generated by LESS/SASS.
> > > >>
> > > >> The browser makes a call to get the .map file only when DevTools are
> > > used.
> > > >>
> > > >> Do you see any issues of adding .map to the whitelist ?
> > > >> If someone doesn't want to serve her non-minified version of some
> > > >> important
> > > >> .js file then (s)he should not add /*sourceMapUrl=...*/ in first
> place
> > > in
> > > >> the content of .min.js.
> > > >>
> > > >>
> > > >> Martin Grigorov
> > > >> Wicket Training and Consulting
> > > >> https://twitter.com/mtgrigorov
> > > >>
> > > >>
> > > >
> > >
>
--
WBR
Maxim aka solomax
Re: Add .map to the list of allowed file extensions in SecurePackageResourceGuard
Posted by Sebastien <se...@gmail.com>.
Hi Maxim,
On Mar 14, 2016 02:49, "Maxim Solodovnik" <so...@gmail.com> wrote:
>
> +1, I recently notice error from kendo-ui regarding *.map files
Me too, I will have a look. Maybe I missed some .map files...
>
> WBR, Maxim
> (from mobile, sorry for the typos)
> On Mar 14, 2016 02:12, "Sebastien" <se...@gmail.com> wrote:
>
> > > I think I have added .map and then removed it once but now I cannot
find
> > it in Git history...
> >
> > Maybe you remembered a wicket-kendo-ui commit?
> >
> >
https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-kendo-ui/src/main/java/com/googlecode/wicket/kendo/ui/Initializer.java#L45
> >
> > I'm definitely +1 to add it.
> >
> > Thanks & best regards,
> > Sebastien
> >
> >
> >
> >
> > On Sun, Mar 13, 2016 at 9:08 PM, Sven Meier <sv...@meiers.net> wrote:
> >
> > > I'm fine with .map on the whitelist.
> > >
> > > Regards
> > > Sven
> > >
> > >
> > > On 13.03.2016 17:43, Martin Grigorov wrote:
> > >
> > >> Hi,
> > >>
> > >> At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user
> > >> requested
> > >> to add .map to SPRG.
> > >> I think I have added .map and then removed it once but now I cannot
find
> > >> it
> > >> in Git history...
> > >>
> > >> .map is used to map generated and/or minified js/css resources to
their
> > >> original version, so one can debug easily.
> > >> E.g. a .css file generated by LESS/SASS.
> > >>
> > >> The browser makes a call to get the .map file only when DevTools are
> > used.
> > >>
> > >> Do you see any issues of adding .map to the whitelist ?
> > >> If someone doesn't want to serve her non-minified version of some
> > >> important
> > >> .js file then (s)he should not add /*sourceMapUrl=...*/ in first
place
> > in
> > >> the content of .min.js.
> > >>
> > >>
> > >> Martin Grigorov
> > >> Wicket Training and Consulting
> > >> https://twitter.com/mtgrigorov
> > >>
> > >>
> > >
> >
Re: Add .map to the list of allowed file extensions in SecurePackageResourceGuard
Posted by Maxim Solodovnik <so...@gmail.com>.
+1, I recently notice error from kendo-ui regarding *.map files
WBR, Maxim
(from mobile, sorry for the typos)
On Mar 14, 2016 02:12, "Sebastien" <se...@gmail.com> wrote:
> > I think I have added .map and then removed it once but now I cannot find
> it in Git history...
>
> Maybe you remembered a wicket-kendo-ui commit?
>
> https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-kendo-ui/src/main/java/com/googlecode/wicket/kendo/ui/Initializer.java#L45
>
> I'm definitely +1 to add it.
>
> Thanks & best regards,
> Sebastien
>
>
>
>
> On Sun, Mar 13, 2016 at 9:08 PM, Sven Meier <sv...@meiers.net> wrote:
>
> > I'm fine with .map on the whitelist.
> >
> > Regards
> > Sven
> >
> >
> > On 13.03.2016 17:43, Martin Grigorov wrote:
> >
> >> Hi,
> >>
> >> At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user
> >> requested
> >> to add .map to SPRG.
> >> I think I have added .map and then removed it once but now I cannot find
> >> it
> >> in Git history...
> >>
> >> .map is used to map generated and/or minified js/css resources to their
> >> original version, so one can debug easily.
> >> E.g. a .css file generated by LESS/SASS.
> >>
> >> The browser makes a call to get the .map file only when DevTools are
> used.
> >>
> >> Do you see any issues of adding .map to the whitelist ?
> >> If someone doesn't want to serve her non-minified version of some
> >> important
> >> .js file then (s)he should not add /*sourceMapUrl=...*/ in first place
> in
> >> the content of .min.js.
> >>
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >>
> >
>
Re: Add .map to the list of allowed file extensions in SecurePackageResourceGuard
Posted by Sebastien <se...@gmail.com>.
> I think I have added .map and then removed it once but now I cannot find
it in Git history...
Maybe you remembered a wicket-kendo-ui commit?
https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-kendo-ui/src/main/java/com/googlecode/wicket/kendo/ui/Initializer.java#L45
I'm definitely +1 to add it.
Thanks & best regards,
Sebastien
On Sun, Mar 13, 2016 at 9:08 PM, Sven Meier <sv...@meiers.net> wrote:
> I'm fine with .map on the whitelist.
>
> Regards
> Sven
>
>
> On 13.03.2016 17:43, Martin Grigorov wrote:
>
>> Hi,
>>
>> At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user
>> requested
>> to add .map to SPRG.
>> I think I have added .map and then removed it once but now I cannot find
>> it
>> in Git history...
>>
>> .map is used to map generated and/or minified js/css resources to their
>> original version, so one can debug easily.
>> E.g. a .css file generated by LESS/SASS.
>>
>> The browser makes a call to get the .map file only when DevTools are used.
>>
>> Do you see any issues of adding .map to the whitelist ?
>> If someone doesn't want to serve her non-minified version of some
>> important
>> .js file then (s)he should not add /*sourceMapUrl=...*/ in first place in
>> the content of .min.js.
>>
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>>
>
Re: Add .map to the list of allowed file extensions in
SecurePackageResourceGuard
Posted by Sven Meier <sv...@meiers.net>.
I'm fine with .map on the whitelist.
Regards
Sven
On 13.03.2016 17:43, Martin Grigorov wrote:
> Hi,
>
> At https://github.com/l0rdn1kk0n/wicket-webjars/issues/41 a user requested
> to add .map to SPRG.
> I think I have added .map and then removed it once but now I cannot find it
> in Git history...
>
> .map is used to map generated and/or minified js/css resources to their
> original version, so one can debug easily.
> E.g. a .css file generated by LESS/SASS.
>
> The browser makes a call to get the .map file only when DevTools are used.
>
> Do you see any issues of adding .map to the whitelist ?
> If someone doesn't want to serve her non-minified version of some important
> .js file then (s)he should not add /*sourceMapUrl=...*/ in first place in
> the content of .min.js.
>
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>