You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/04/21 17:19:29 UTC
[jclouds/jclouds] JCLOUDS-1105: Do not create the default security
group if custom groups are specified (#947)
https://issues.apache.org/jira/browse/JCLOUDS-1105
I'm still not sure about the impact of this change. I'd rather play a bit with this and get feedback from users. I haven't been able to test it live yet, so this PR just relies on the unit tests. I plan to do some testing later today but I'd love to get some feedback from others too.
/cc @andreaturli @aledsage @andras-nemes
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/947
-- Commit Summary --
* JCLOUDS-1105: Do not create the default security group if custom groups are specified
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/compute/strategy/CreateKeyPairAndSecurityGroupsAsNeededAndReturnRunOptions.java (11)
M apis/ec2/src/test/java/org/jclouds/ec2/compute/strategy/CreateKeyPairAndSecurityGroupsAsNeededAndReturnRunOptionsTest.java (13)
M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/strategy/CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptionsTest.java (26)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/947.patch
https://github.com/jclouds/jclouds/pull/947.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Ignasi Barrera <no...@github.com>.
@marcocast Expect it to be merged this week. I running the live test in my backlog. I'll try to run them today.
In any case, if you can run the live tests and share the results in a gist or pastie, that would be great :) There are some that are already failing, but I just want to run the entire suite and verify this change is not breaking anything that is working now.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#issuecomment-221823040
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [bde70457](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bde70457). Thanks everyone!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#issuecomment-226877388
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Ignasi Barrera <no...@github.com>.
Closed #947.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#event-696441596
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Andras Nemes <no...@github.com>.
Thanks for your quick reaction and feedback. I think it the code looks good.
//Andras
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#issuecomment-214205585
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Marco Castigliego <no...@github.com>.
@nacx Thanks man.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#issuecomment-221872895
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Marco Castigliego <no...@github.com>.
Hi Guys,
any idea on when this patch will be merged? We have the same problem and we would love to have the fix as soon as possible.
Thanks!!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#issuecomment-221802057
Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default
security group if custom groups are specified (#947)
Posted by Andrea Turli <no...@github.com>.
@nacx code looks sensible +1
I will keep this PR in mind if we need to revert/change the implementation later on, ok?
Thanks!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/947#issuecomment-216151418