You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jordan West (Jira)" <ji...@apache.org> on 2020/09/11 20:53:00 UTC

[jira] [Comment Edited] (CASSANDRA-16048) Safely Ignore Compact Storage Tables Where Users Have Defined Clustering and Value Columns

    [ https://issues.apache.org/jira/browse/CASSANDRA-16048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194524#comment-17194524 ] 

Jordan West edited comment on CASSANDRA-16048 at 9/11/20, 8:52 PM:
-------------------------------------------------------------------

[~ifesdjeen] do you have a repro of that? I added some column level deletes in a [test I added previously | https://github.com/apache/cassandra/blob/cassandra-3.0/test/distributed/org/apache/cassandra/distributed/upgrade/CompactStorage2to3UpgradeTest.java#L190] and didn't discover any issues. Admittedly, it could be more robust and there may be a case I missed (aside: it would be nice to have Harry for this), but if you have a repro to share that would be super helpful. Thanks!


was (Author: jrwest):
[~ifesdjeen] do you have a repro of that? I added some column level deletes in a [test I added previously | https://github.com/apache/cassandra/blob/cassandra-3.0/test/distributed/org/apache/cassandra/distributed/upgrade/CompactStorage2to3UpgradeTest.java#L190] and it didn't source any issues. Admittedly, it could be more robust and there may be a case I missed (aside: it would be nice to have Harry for this), but if you have a repro to share that would be super helpful. Thanks!

> Safely Ignore Compact Storage Tables Where Users Have Defined Clustering and Value Columns
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16048
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16048
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/CQL
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> Some compact storage tables, specifically those where the user has defined both at least one clustering and the value column, can be safely handled in 4.0 because besides the DENSE flag they are not materially different post 3.0 and there is no visible change to the user facing schema after dropping compact storage. We can detect this case and allow these tables to silently drop the DENSE flag while still throwing a start-up error for COMPACT STORAGE tables that don’t meet the criteria. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org