You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/06/24 11:59:34 UTC
[PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
lhotari opened a new pull request, #4446:
URL: https://github.com/apache/bookkeeper/pull/4446
### Motivation
There doesn't seem to be a need to retain support for Java 8 and Java 11 in new releases of Bookkeeper.
Java 11 is EOL in October.
Please see mailing list discussion https://lists.apache.org/thread/gtp4j5y9txzlz0pfgfhy3gz4q4ptnlo8
### Changes
- Enforce Java 17 or Java 21 for building Bookkeeper
- Set `<release>17</release>` for `maven-compiler-plugin` by default
- keep Java 8 compatibility in `cpu-affinity` and `circe-checksum` since Pulsar's Java client uses them.
- Replace Java 11 usage with Java 17 in CI
- Remove CI jobs using Java 8 or Java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-3985717819
I have rebased this PR so that we could merge this for 4.18.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17+ for building and running Bookkeeper [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-2324690417
> > I think we should first refactor BK client into a separate module that will be built with JDK 8, then we can move BK server to JDK 17
>
> My two cents working for java11 and not java8 if we want to refactor BK client into a separate module,java8 is becoming a liability.
There's also maintenance branches with Java 8 support, I don't see a point keeping support for JDK 8 in the future versions of Bookkeeper. Existing Java 8 users can continue to use maintenance branches until they have migrated to newer JDK versions. I think that master branch should set the minimum JDK version to either Java 17 or Java 21 and leave the previous JDK versions to be handled by maintenance branches.
Can we even find a single BK users that runs a recent BK version on Java 8? It's definitely a completely unnecessary liability to keep supporting Java 8 in the master branch and future BK versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-2661822866
I agree to update jdk version in 4.18.0. Generally, we should align major JDK upgrades with a major version bump like 5.0.0 for the client. However, considering the imminent EOL of Java 11 and Java 8, it might still be acceptable to perform the JDK upgrade in a feature release like 4.18.0. After all, users who are reluctant to upgrade their JDKs are likely less interested in new features—as long as we continue providing bug fixes for the older JDK 8/11 branches, the impact would be minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-3998243141
Will split ZooKeeper HostProvider to a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "liangyuanpeng (via GitHub)" <gi...@apache.org>.
liangyuanpeng commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-2324056187
> I think we should first refactor BK client into a separate module that will be built with JDK 8, then we can move BK server to JDK 17
My two cents
working for java11 and not java8 if we want to refactor BK client into a separate module,java8 is becoming a liability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-2679888477
> I guess, it's better to keep jdk-11 support for sometime as some legacy systems are still running old bookkeeper version, and upgrading bookie is also upgrades rocksDB version where I saw some incompatibility between rocksDB-5.x and rocksDB-7.x where it doesn't allow to downgrade bookkeeper because rocksDB-7.x introduced unknown tags in MANIFEST file which is not recoverable by rocksDB-5.x if one wants to downgrade bookie.
There's no requirement to upgrade the bookies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT closed pull request #4446: Require Java 17 or Java 21 for building Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/4446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-2661825058
PRs that have not been processed for a long time will be closed first. Please open them yourself if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require Java 17 or Java 21 for building Bookkeeper [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #4446:
URL: https://github.com/apache/bookkeeper/pull/4446#issuecomment-3985738415
This is needed for Jetty 12 upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org