You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/02/12 00:03:00 UTC
Review Request 43503: Making OfferManager.getOffers() return a new set
rather than a view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
Benchmark testing, as expected, did not show any meaningful changes in performance:
Before:
```
Benchmark (numPendingTasks) Mode Cnt Score Error Units
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
```
After:
```
Benchmark (numPendingTasks) Mode Cnt Score Error Units
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
```
Diffs
-----
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
Diff: https://reviews.apache.org/r/43503/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118963
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 11, 2016, 3:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 3:03 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1615
> https://issues.apache.org/jira/browse/AURORA-1615
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Benchmark testing, as expected, did not show any meaningful changes in performance:
> Before:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
> ```
> After:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
> ```
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
>
> Diff: https://reviews.apache.org/r/43503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118968
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Feb. 11, 2016, 3:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 3:03 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1615
> https://issues.apache.org/jira/browse/AURORA-1615
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Benchmark testing, as expected, did not show any meaningful changes in performance:
> Before:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
> ```
> After:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
> ```
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
>
> Diff: https://reviews.apache.org/r/43503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118960
-----------------------------------------------------------
Master (0650b8d) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 11, 2016, 11:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 11:03 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1615
> https://issues.apache.org/jira/browse/AURORA-1615
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Benchmark testing, as expected, did not show any meaningful changes in performance:
> Before:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
> ```
> After:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
> ```
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
>
> Diff: https://reviews.apache.org/r/43503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118967
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Feb. 12, 2016, 12:03 vorm., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43503/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 12:03 vorm.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1615
> https://issues.apache.org/jira/browse/AURORA-1615
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Benchmark testing, as expected, did not show any meaningful changes in performance:
> Before:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
> ```
> After:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
> ```
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
>
> Diff: https://reviews.apache.org/r/43503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118955
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On Feb. 11, 2016, 11:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 11:03 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1615
> https://issues.apache.org/jira/browse/AURORA-1615
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Benchmark testing, as expected, did not show any meaningful changes in performance:
> Before:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
> ```
> After:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
> ```
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
>
> Diff: https://reviews.apache.org/r/43503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118949
-----------------------------------------------------------
Master (0650b8d) is red with this patch.
./build-support/jenkins/build.sh
+ date
Thu Feb 11 23:16:07 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open cp_proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj).
> Timeout waiting to lock cp_proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj). It is currently in use by another Gradle instance.
Owner PID: unknown
Our PID: 22658
Owner Operation: unknown
Our operation: Initialize cache
Lock file: /home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj/cache.properties.lock
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 33.027 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 11, 2016, 11:03 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 11:03 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1615
> https://issues.apache.org/jira/browse/AURORA-1615
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Benchmark testing, as expected, did not show any meaningful changes in performance:
> Before:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
> ```
> After:
> ```
> Benchmark (numPendingTasks) Mode Cnt Score Error Units
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
> ```
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
>
> Diff: https://reviews.apache.org/r/43503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43503: Making OfferManager.getOffers() return a
new set rather than a view
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 11:03 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
+ticket
Bugs: AURORA-1615
https://issues.apache.org/jira/browse/AURORA-1615
Repository: aurora
Description
-------
Benchmark testing, as expected, did not show any meaningful changes in performance:
Before:
```
Benchmark (numPendingTasks) Mode Cnt Score Error Units
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 60.414 ± 1.630 ops/s
```
After:
```
Benchmark (numPendingTasks) Mode Cnt Score Error Units
SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 61.167 ± 1.169 ops/s
```
Diffs
-----
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 394d25f8a496ee24505387e5767acf458cb3f5f4
Diff: https://reviews.apache.org/r/43503/diff/
Testing
-------
Thanks,
Maxim Khutornenko