You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by K0zka <gi...@git.apache.org> on 2015/02/27 21:31:30 UTC

[GitHub] cloudstack pull request: Cloudstack 8279

GitHub user K0zka opened a pull request:

    https://github.com/apache/cloudstack/pull/90

    Cloudstack 8279

    Fixes for [CLOUDSTACK-8279](https://issues.apache.org/jira/browse/CLOUDSTACK-8279) and two minor cleanups

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/K0zka/cloudstack CLOUDSTACK-8279

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #90
    
----
commit 5626a340dd271ec585f973dfa99a2a7fb45abac3
Author: Laszlo Hornyak <la...@gmail.com>
Date:   2015-02-25T19:55:56Z

    Logical expression simplification, == true is redundant
    
    Signed-off-by: Laszlo Hornyak <la...@gmail.com>

commit e6e3a20bd6ef95d40af2018c74430a0b5f77166b
Author: Laszlo Hornyak <la...@gmail.com>
Date:   2015-02-25T19:58:25Z

    removed redundant autoboxing
    
    Signed-off-by: Laszlo Hornyak <la...@gmail.com>

commit f8c003d13a4b26839712d8534f8b89fa00dc1275
Author: Laszlo Hornyak <la...@gmail.com>
Date:   2015-02-27T18:03:08Z

    CLOUDSTACK-8279: test fix for java 1.8
    
    The test build on an assumption on the order of items in a Set, while this changed in java 1.8
    
    Signed-off-by: Laszlo Hornyak <la...@gmail.com>

commit df11bb28110d49b5a46790c351a3f309b5c6569e
Author: Laszlo Hornyak <la...@gmail.com>
Date:   2015-02-27T19:06:27Z

    CLOUDSTACK-8279: Fix unit test for java 1.8
    
    Signed-off-by: Laszlo Hornyak <la...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8279

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8279

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/90#issuecomment-76482904
  
    LGTM, good effort. I think the logic to check can be improved by doing a split+sort+search instead of contains but it's good enough to start using jdk 1.8!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---