You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2015/04/11 19:59:02 UTC
[1/2] wicket git commit: Revert "WICKET-5875
ComponentRenderer.renderComponent() unexpectedly produces a"
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x c8980e57c -> 525616ceb
Revert "WICKET-5875 ComponentRenderer.renderComponent() unexpectedly produces a"
This reverts commit c8980e57c6809a2f771a30565ca281557631b06f.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b962ac74
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b962ac74
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b962ac74
Branch: refs/heads/wicket-6.x
Commit: b962ac74f7c36fceb3373bb762b9dde4bc1f9075
Parents: c8980e5
Author: Andrea Del Bene <ad...@apache.org>
Authored: Sat Apr 11 19:53:47 2015 +0200
Committer: Andrea Del Bene <ad...@apache.org>
Committed: Sat Apr 11 19:53:47 2015 +0200
----------------------------------------------------------------------
.../wicket/core/util/string/ComponentRenderer.java | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/b962ac74/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java b/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
index 5be9cf8..b2e84dc 100644
--- a/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
@@ -94,13 +94,10 @@ public class ComponentRenderer
{
requestCycle.setResponse(tempResponse);
- if (component.getParent() == null)
- {
- // add the component to a dummy page just for the rendering
- RenderPage page = new RenderPage(component);
- page.internalInitialize();
- }
-
+ // add the component to a dummy page just for the rendering
+ RenderPage page = new RenderPage(component);
+ page.internalInitialize();
+
component.render();
}
finally
[2/2] wicket git commit: Reverted change for WICKET-5875 and added
docs for method renderComponent
Posted by ad...@apache.org.
Reverted change for WICKET-5875 and added docs for method
renderComponent
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/525616ce
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/525616ce
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/525616ce
Branch: refs/heads/wicket-6.x
Commit: 525616ceb1cc273270e54c06f285f02f576c330f
Parents: b962ac7
Author: Andrea Del Bene <ad...@apache.org>
Authored: Sat Apr 11 19:57:24 2015 +0200
Committer: Andrea Del Bene <ad...@apache.org>
Committed: Sat Apr 11 19:57:24 2015 +0200
----------------------------------------------------------------------
.../org/apache/wicket/core/util/string/ComponentRenderer.java | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/525616ce/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java b/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
index b2e84dc..1c0131e 100644
--- a/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java
@@ -76,6 +76,10 @@ public class ComponentRenderer
/**
* Collects the html generated by the rendering of a component.
+ *
+ * NOTE: this method i meant to render fresh component instances that are disposed after the
+ * html has been generate. To avoid unwanted side effects do not use it with components that
+ * are from an existing hierarchy.
*
* @param component
* the component to render.