[GitHub] [superset] zhaoyongjie commented on pull request #18080: feat: smart tooltip in datasourcepanel

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18080:
URL: https://github.com/apache/superset/pull/18080#issuecomment-1031118056


   > 
   > If I'm not mistaken (4) means you no longer have access to see the column name. I think we should indeed show the (non-truncated) verbose name AND the column name in the tooltip. This is weird, because it's not consistent. But, I don't think it's a good idea to hide information users might see as important.
   > 
   > Another option I think I would prefer, is to make 3&4 consistent. This would mean showing the Verbose AND Column names in (3) and (4). For 3, the information is a bit redundant, but it at least establishes a regular pattern, so users don't have to think as much about what they're seeing as they go through the list.
   
   Nice method, I will update this PR for cases (3) and (4). Always showing *verbose name* and *column name* in the tooltip if column/metric has a verbose name.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org