You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:51:58 UTC

[GitHub] [incubator-pinot] shahsank3t opened a new pull request #5763: adding zookeeper browser module in UI

shahsank3t opened a new pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763


   ## Description
   This PR is to add the Zookeeper Browser module into existing UI.
   ![image](https://user-images.githubusercontent.com/6761317/88699639-361bad00-d125-11ea-85e2-7960ca1db617.png)
   ![image](https://user-images.githubusercontent.com/6761317/88699753-5d727a00-d125-11ea-931a-963d7d0bd104.png)
   
   Added `Refresh` action functuality.
   Added a "Functionality Coming Soon" text on `Add`, `Edit`, `Delete` Options in ZK Browser.
   ![image](https://user-images.githubusercontent.com/6761317/88700005-af1b0480-d125-11ea-83f5-a4decd8379f0.png)
   
   A couple of additional changes:
   1. Replace "Open Sans" font with "Source Sans Pro"
   2. The backdrop on the loading sign was giving an experience of screen flicker, fixed it by showing the loader on the top right part of the screen.
   ![image](https://user-images.githubusercontent.com/6761317/88700393-41bba380-d126-11ea-8c3c-10b36447c989.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] kishoreg merged pull request #5763: adding zookeeper browser module in UI

Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] kishoreg commented on pull request #5763: adding zookeeper browser module in UI

Posted by GitBox <gi...@apache.org>.
kishoreg commented on pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763#issuecomment-665187267






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] fx19880617 commented on pull request #5763: adding zookeeper browser module in UI

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763#issuecomment-665215001


   This is awesome!
   
   Two features maybe useful:
   1. Show decoded message for compressed metadata. (E.g. large idealStates is compressed)
   2. Search support based on either znode name and node content
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] yupeng9 commented on pull request #5763: adding zookeeper browser module in UI

Posted by GitBox <gi...@apache.org>.
yupeng9 commented on pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763#issuecomment-665380502


    This is awesome!
   
   +1 to the search/filter support on the creation/updated time, to show most recent state changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] shahsank3t commented on pull request #5763: adding zookeeper browser module in UI

Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763#issuecomment-665189824


   @kishoreg 
   Addressed the comment and updated the PR.
   ![image](https://user-images.githubusercontent.com/6761317/88703646-95c88700-d12a-11ea-87b4-6800adcdf72b.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] yupeng9 commented on pull request #5763: adding zookeeper browser module in UI

Posted by GitBox <gi...@apache.org>.
yupeng9 commented on pull request #5763:
URL: https://github.com/apache/incubator-pinot/pull/5763#issuecomment-665765905


   > > This is awesome!
   > > +1 to the search/filter support on the creation/updated time, to show most recent state changes.
   > 
   > @yupeng9, can you elaborate on this? are you talking about ZK explorer.
   
   Yes, I was referring to the ZK explorer with a filter on ctime or mtime to inspect the recent changes or changes in a given time window.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org