You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/04 12:51:31 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4025:
Extend stream interfaces to expose message metadata like ingestion timestamp
codecov-io edited a comment on issue #4025: Extend stream interfaces to expose message metadata like ingestion timestamp
URL: https://github.com/apache/incubator-pinot/pull/4025#issuecomment-477814425
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=h1) Report
> Merging [#4025](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8036bffbc8113c8bf0fcdef6b3ac21851a9c72e8?src=pr&el=desc) will **decrease** coverage by `15.95%`.
> The diff coverage is `81.08%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4025 +/- ##
=============================================
- Coverage 56.95% 40.99% -15.96%
=============================================
Files 1033 1160 +127
Lines 51375 58359 +6984
Branches 7193 8105 +912
=============================================
- Hits 29259 23925 -5334
- Misses 19952 32367 +12415
+ Partials 2164 2067 -97
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...not/core/realtime/stream/StreamMessageDecoder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vU3RyZWFtTWVzc2FnZURlY29kZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...pache/pinot/core/realtime/stream/MessageBatch.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vTWVzc2FnZUJhdGNoLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../realtime/impl/kafka/KafkaStreamLevelConsumer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2thZmthL0thZmthU3RyZWFtTGV2ZWxDb25zdW1lci5qYXZh) | `78.84% <100%> (+78.84%)` | `0 <0> (ø)` | :arrow_down: |
| [...manager/realtime/HLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvSExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `81.12% <100%> (+81.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/core/realtime/stream/StreamLevelConsumer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vU3RyZWFtTGV2ZWxDb25zdW1lci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `54.79% <100%> (+11.2%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/core/realtime/stream/StreamMessageMetadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vU3RyZWFtTWVzc2FnZU1ldGFkYXRhLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../pinot/core/segment/index/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `62.55% <50%> (-18.63%)` | `0 <0> (ø)` | |
| [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `56.88% <64.28%> (+9.96%)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [834 more](https://codecov.io/gh/apache/incubator-pinot/pull/4025/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=footer). Last update [8036bff...dad00ad](https://codecov.io/gh/apache/incubator-pinot/pull/4025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org