You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by OmPrakash Muppirala <bi...@gmail.com> on 2013/08/09 19:12:24 UTC
120 and 640 dpi support
Justin,
Please assign the 120 and 640 dpi JIRA tickets to me. I will have some
bandwidth to work on them in the next week.
I will also use this opportunity to clean up the tool I wrote to up-convert
the 320 dpi skins to 480 dpi and check it in for future use.
Thanks,
Om
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I see the changes you made in the new branch. Is resizing the fxg files
> the only thing remaining?
Nope you have to change all the action script skins as well. There's about 100 odd files there that need changes and you need to look carefully as it not always a simple doubling (from 320) or halving (from 240).
I've also not checked if the new scaling mustella tests work.
> So, for the 640 dpi skins, it makes sense to take the 160 dpi skins and
> quadruple the scale for each element in the FXG. This guarantees best
> performance.
-1 I'd still take the 320 and double, the 320 have some difference that improve quality IMO and a 640 dpi device is likely to be top of the range devipe with more memory and faster CPU than most.
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I have run into at least one major problem. Some of the FXG assets use the
viewHeight and viewWidth properties. This causes the asset to not scale.
So I am seeing artifacts in my mobile app in the new dpis (120, 480 and 640)
I am going to try removing these properties because we want them to scale
as needed. I will keep the older dpis' assets untouched. They seem to
have been hand-crafted and hence better tested.
Thanks,
Om
On Tue, Aug 20, 2013 at 10:56 AM, OmPrakash Muppirala
<bi...@gmail.com>wrote:
> A restart and a clean build fixed everything for me. Sorry for the
> noise.
>
> I will do a release build and test it with my current mobile apps and send
> out a report this evening.
>
> Thanks,
> Om
>
>
> On Mon, Aug 19, 2013 at 7:49 PM, OmPrakash Muppirala <bigosmallm@gmail.com
> > wrote:
>
>> That helps, thanks for testing. I am going to try my luck with develop
>> branch and see if it is still broken for me.
>>
>> Anyone else on Windows willing to test and confirm?
>>
>> Thanks,
>> Om
>> On Aug 19, 2013 7:42 PM, "Justin Mclean" <ju...@classsoftware.com>
>> wrote:
>>
>>> Hi,
>>>
>>> And it did run to completion without any issues - know that doesn't help
>>> you sorry.
>>>
>>> release:
>>>
>>> BUILD SUCCESSFUL
>>> Total time: 76 minutes 20 seconds
>>>
>>> Justin
>>>
>>>
>>>
>
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
A restart and a clean build fixed everything for me. Sorry for the noise.
I will do a release build and test it with my current mobile apps and send
out a report this evening.
Thanks,
Om
On Mon, Aug 19, 2013 at 7:49 PM, OmPrakash Muppirala
<bi...@gmail.com>wrote:
> That helps, thanks for testing. I am going to try my luck with develop
> branch and see if it is still broken for me.
>
> Anyone else on Windows willing to test and confirm?
>
> Thanks,
> Om
> On Aug 19, 2013 7:42 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
>> Hi,
>>
>> And it did run to completion without any issues - know that doesn't help
>> you sorry.
>>
>> release:
>>
>> BUILD SUCCESSFUL
>> Total time: 76 minutes 20 seconds
>>
>> Justin
>>
>>
>>
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
That helps, thanks for testing. I am going to try my luck with develop
branch and see if it is still broken for me.
Anyone else on Windows willing to test and confirm?
Thanks,
Om
On Aug 19, 2013 7:42 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
> And it did run to completion without any issues - know that doesn't help
> you sorry.
>
> release:
>
> BUILD SUCCESSFUL
> Total time: 76 minutes 20 seconds
>
> Justin
>
>
>
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
And it did run to completion without any issues - know that doesn't help you sorry.
release:
BUILD SUCCESSFUL
Total time: 76 minutes 20 seconds
Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Also no issue with "ant release" - although the build number is "0" because it was not specified.
[mxmlc] Loading configuration file /Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/flex-config.xml
[mxmlc] Required RSLs:
[mxmlc] framework_0.swf
[mxmlc] textLayout_0.swf
[mxmlc] spark_0.swf
[mxmlc] osmf_0.swf
[mxmlc] /Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/tests/basicTests/spark/views/HelloWorld.swf (49201 bytes)
[echo] launching player and swf
mustellaresultsparser:
[java] results: PASSED
Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
JFYI - Synced the NewDPIBuckets branch and was able to do a "ant clean main checkintests" with no issues, Checkin tests passed, on OSX btw.
Thanks,
Justin
Re: 120 and 640 dpi support
Posted by Alex Harui <ah...@adobe.com>.
I"m deep in a compiler issue right now. First step is to try "ant clean
main checkintests". Does it fail in that case?
-Alex
On 8/19/13 3:49 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>Can you try building the 'NewDPIBuckets' branch and see if you hit this
>issue as well? I am simply doing an 'ant release' - nothing other than
>the
>new mobile skins has changed AFAIK.
>
>Thanks,
>Om
>
>
>On Mon, Aug 19, 2013 at 2:21 PM, Alex Harui <ah...@adobe.com> wrote:
>
>> I didn't think basictests ran in RSL config. I always thought it was
>> merged-into-code.
>>
>> -Alex
>>
>> On 8/19/13 2:18 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>>
>> >And the RSL swfs' versions are wrong too, right?
>> >
>> >
>> >On Mon, Aug 19, 2013 at 2:15 PM, Alex Harui <ah...@adobe.com> wrote:
>> >
>> >> Helloworld.swf seems too small.
>> >>
>> >> On 8/19/13 10:13 AM, "OmPrakash Muppirala" <bi...@gmail.com>
>> wrote:
>> >>
>> >> >I am done creating the new skins for both 120 and 640 dpi. But
>>when I
>> >>do
>> >> >a
>> >> >release build, I am see that my Flash Player debugger freezes when
>> >>running
>> >> >the basicTests. The version is
>> >> >flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is:
>> >> >'NewDPIBuckets'.
>> >> >
>> >> >Anyone has any advice?
>> >> >
>> >> >================================================
>> >> >basictests:
>> >> > [mxmlc] Loading configuration file
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >> >sdk\frameworks\flex-config.xml
>> >> > [mxmlc] Loading configuration file
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >> >sdk\frameworks\tests\basicTests\BasicTests-config.xml
>> >> > [mxmlc]
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >> >ests\BasicTests.swf (3723680 bytes)
>> >> > [mxmlc] Loading configuration file
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >> >sdk\frameworks\flex-config.xml
>> >> > [mxmlc]
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >> >ests\basicLoader.swf (956 bytes)
>> >> > [mxmlc] Loading configuration file
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >> >sdk\frameworks\flex-config.xml
>> >> > [mxmlc]
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >> >ests\spark\views\StyleManagerModuleTest.swf (517379 bytes)
>> >> > [mxmlc] Loading configuration file
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >> >sdk\frameworks\flex-config.xml
>> >> > [mxmlc] Required RSLs:
>> >> > [mxmlc] framework_0.swf
>> >> > [mxmlc] textLayout_0.swf
>> >> > [mxmlc] spark_0.swf
>> >> > [mxmlc] osmf_0.swf
>> >> > [mxmlc]
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >> >ests\spark\views\HelloWorld.swf (49207 bytes)
>> >> > [echo] launching player and swf
>> >> >
>> >> >BUILD FAILED
>> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:1436: exec
>> >> >returned:
>> >> >-107
>> >> >3741819
>> >> >
>> >> >Total time: 474 minutes 38 seconds
>> >> >================================================
>> >> >
>> >> >Thanks,
>> >> >Om
>> >> >
>> >> >
>> >> >On Sun, Aug 18, 2013 at 9:57 AM, OmPrakash Muppirala
>> >> ><bi...@gmail.com>wrote:
>> >> >
>> >> >> Will do. Thanks!
>> >> >>
>> >> >>
>> >> >> On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean
>> >> >><ju...@classsoftware.com>wrote:
>> >> >>
>> >> >>> Hi,
>> >> >>>
>> >> >>> I've just checked in the ones you missed - can you fix so that
>>they
>> >>are
>> >> >>> 120 dpi?
>> >> >>>
>> >> >>> Thanks,
>> >> >>> Justin
>> >> >>
>> >> >>
>> >> >>
>> >>
>> >>
>>
>>
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Can you try building the 'NewDPIBuckets' branch and see if you hit this
issue as well? I am simply doing an 'ant release' - nothing other than the
new mobile skins has changed AFAIK.
Thanks,
Om
On Mon, Aug 19, 2013 at 2:21 PM, Alex Harui <ah...@adobe.com> wrote:
> I didn't think basictests ran in RSL config. I always thought it was
> merged-into-code.
>
> -Alex
>
> On 8/19/13 2:18 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >And the RSL swfs' versions are wrong too, right?
> >
> >
> >On Mon, Aug 19, 2013 at 2:15 PM, Alex Harui <ah...@adobe.com> wrote:
> >
> >> Helloworld.swf seems too small.
> >>
> >> On 8/19/13 10:13 AM, "OmPrakash Muppirala" <bi...@gmail.com>
> wrote:
> >>
> >> >I am done creating the new skins for both 120 and 640 dpi. But when I
> >>do
> >> >a
> >> >release build, I am see that my Flash Player debugger freezes when
> >>running
> >> >the basicTests. The version is
> >> >flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is:
> >> >'NewDPIBuckets'.
> >> >
> >> >Anyone has any advice?
> >> >
> >> >================================================
> >> >basictests:
> >> > [mxmlc] Loading configuration file
> >> >C:\p\flex_os\workspace\flexroot\git\flex-
> >> >sdk\frameworks\flex-config.xml
> >> > [mxmlc] Loading configuration file
> >> >C:\p\flex_os\workspace\flexroot\git\flex-
> >> >sdk\frameworks\tests\basicTests\BasicTests-config.xml
> >> > [mxmlc]
> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >> >ests\BasicTests.swf (3723680 bytes)
> >> > [mxmlc] Loading configuration file
> >> >C:\p\flex_os\workspace\flexroot\git\flex-
> >> >sdk\frameworks\flex-config.xml
> >> > [mxmlc]
> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >> >ests\basicLoader.swf (956 bytes)
> >> > [mxmlc] Loading configuration file
> >> >C:\p\flex_os\workspace\flexroot\git\flex-
> >> >sdk\frameworks\flex-config.xml
> >> > [mxmlc]
> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >> >ests\spark\views\StyleManagerModuleTest.swf (517379 bytes)
> >> > [mxmlc] Loading configuration file
> >> >C:\p\flex_os\workspace\flexroot\git\flex-
> >> >sdk\frameworks\flex-config.xml
> >> > [mxmlc] Required RSLs:
> >> > [mxmlc] framework_0.swf
> >> > [mxmlc] textLayout_0.swf
> >> > [mxmlc] spark_0.swf
> >> > [mxmlc] osmf_0.swf
> >> > [mxmlc]
> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >> >ests\spark\views\HelloWorld.swf (49207 bytes)
> >> > [echo] launching player and swf
> >> >
> >> >BUILD FAILED
> >> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:1436: exec
> >> >returned:
> >> >-107
> >> >3741819
> >> >
> >> >Total time: 474 minutes 38 seconds
> >> >================================================
> >> >
> >> >Thanks,
> >> >Om
> >> >
> >> >
> >> >On Sun, Aug 18, 2013 at 9:57 AM, OmPrakash Muppirala
> >> ><bi...@gmail.com>wrote:
> >> >
> >> >> Will do. Thanks!
> >> >>
> >> >>
> >> >> On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean
> >> >><ju...@classsoftware.com>wrote:
> >> >>
> >> >>> Hi,
> >> >>>
> >> >>> I've just checked in the ones you missed - can you fix so that they
> >>are
> >> >>> 120 dpi?
> >> >>>
> >> >>> Thanks,
> >> >>> Justin
> >> >>
> >> >>
> >> >>
> >>
> >>
>
>
Re: 120 and 640 dpi support
Posted by Alex Harui <ah...@adobe.com>.
I didn't think basictests ran in RSL config. I always thought it was
merged-into-code.
-Alex
On 8/19/13 2:18 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>And the RSL swfs' versions are wrong too, right?
>
>
>On Mon, Aug 19, 2013 at 2:15 PM, Alex Harui <ah...@adobe.com> wrote:
>
>> Helloworld.swf seems too small.
>>
>> On 8/19/13 10:13 AM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>>
>> >I am done creating the new skins for both 120 and 640 dpi. But when I
>>do
>> >a
>> >release build, I am see that my Flash Player debugger freezes when
>>running
>> >the basicTests. The version is
>> >flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is:
>> >'NewDPIBuckets'.
>> >
>> >Anyone has any advice?
>> >
>> >================================================
>> >basictests:
>> > [mxmlc] Loading configuration file
>> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >sdk\frameworks\flex-config.xml
>> > [mxmlc] Loading configuration file
>> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >sdk\frameworks\tests\basicTests\BasicTests-config.xml
>> > [mxmlc]
>> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >ests\BasicTests.swf (3723680 bytes)
>> > [mxmlc] Loading configuration file
>> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >sdk\frameworks\flex-config.xml
>> > [mxmlc]
>> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >ests\basicLoader.swf (956 bytes)
>> > [mxmlc] Loading configuration file
>> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >sdk\frameworks\flex-config.xml
>> > [mxmlc]
>> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >ests\spark\views\StyleManagerModuleTest.swf (517379 bytes)
>> > [mxmlc] Loading configuration file
>> >C:\p\flex_os\workspace\flexroot\git\flex-
>> >sdk\frameworks\flex-config.xml
>> > [mxmlc] Required RSLs:
>> > [mxmlc] framework_0.swf
>> > [mxmlc] textLayout_0.swf
>> > [mxmlc] spark_0.swf
>> > [mxmlc] osmf_0.swf
>> > [mxmlc]
>> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>> >ests\spark\views\HelloWorld.swf (49207 bytes)
>> > [echo] launching player and swf
>> >
>> >BUILD FAILED
>> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:1436: exec
>> >returned:
>> >-107
>> >3741819
>> >
>> >Total time: 474 minutes 38 seconds
>> >================================================
>> >
>> >Thanks,
>> >Om
>> >
>> >
>> >On Sun, Aug 18, 2013 at 9:57 AM, OmPrakash Muppirala
>> ><bi...@gmail.com>wrote:
>> >
>> >> Will do. Thanks!
>> >>
>> >>
>> >> On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean
>> >><ju...@classsoftware.com>wrote:
>> >>
>> >>> Hi,
>> >>>
>> >>> I've just checked in the ones you missed - can you fix so that they
>>are
>> >>> 120 dpi?
>> >>>
>> >>> Thanks,
>> >>> Justin
>> >>
>> >>
>> >>
>>
>>
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
And the RSL swfs' versions are wrong too, right?
On Mon, Aug 19, 2013 at 2:15 PM, Alex Harui <ah...@adobe.com> wrote:
> Helloworld.swf seems too small.
>
> On 8/19/13 10:13 AM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >I am done creating the new skins for both 120 and 640 dpi. But when I do
> >a
> >release build, I am see that my Flash Player debugger freezes when running
> >the basicTests. The version is
> >flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is:
> >'NewDPIBuckets'.
> >
> >Anyone has any advice?
> >
> >================================================
> >basictests:
> > [mxmlc] Loading configuration file
> >C:\p\flex_os\workspace\flexroot\git\flex-
> >sdk\frameworks\flex-config.xml
> > [mxmlc] Loading configuration file
> >C:\p\flex_os\workspace\flexroot\git\flex-
> >sdk\frameworks\tests\basicTests\BasicTests-config.xml
> > [mxmlc]
> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >ests\BasicTests.swf (3723680 bytes)
> > [mxmlc] Loading configuration file
> >C:\p\flex_os\workspace\flexroot\git\flex-
> >sdk\frameworks\flex-config.xml
> > [mxmlc]
> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >ests\basicLoader.swf (956 bytes)
> > [mxmlc] Loading configuration file
> >C:\p\flex_os\workspace\flexroot\git\flex-
> >sdk\frameworks\flex-config.xml
> > [mxmlc]
> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >ests\spark\views\StyleManagerModuleTest.swf (517379 bytes)
> > [mxmlc] Loading configuration file
> >C:\p\flex_os\workspace\flexroot\git\flex-
> >sdk\frameworks\flex-config.xml
> > [mxmlc] Required RSLs:
> > [mxmlc] framework_0.swf
> > [mxmlc] textLayout_0.swf
> > [mxmlc] spark_0.swf
> > [mxmlc] osmf_0.swf
> > [mxmlc]
> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
> >ests\spark\views\HelloWorld.swf (49207 bytes)
> > [echo] launching player and swf
> >
> >BUILD FAILED
> >C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:1436: exec
> >returned:
> >-107
> >3741819
> >
> >Total time: 474 minutes 38 seconds
> >================================================
> >
> >Thanks,
> >Om
> >
> >
> >On Sun, Aug 18, 2013 at 9:57 AM, OmPrakash Muppirala
> ><bi...@gmail.com>wrote:
> >
> >> Will do. Thanks!
> >>
> >>
> >> On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean
> >><ju...@classsoftware.com>wrote:
> >>
> >>> Hi,
> >>>
> >>> I've just checked in the ones you missed - can you fix so that they are
> >>> 120 dpi?
> >>>
> >>> Thanks,
> >>> Justin
> >>
> >>
> >>
>
>
Re: 120 and 640 dpi support
Posted by Alex Harui <ah...@adobe.com>.
Helloworld.swf seems too small.
On 8/19/13 10:13 AM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>I am done creating the new skins for both 120 and 640 dpi. But when I do
>a
>release build, I am see that my Flash Player debugger freezes when running
>the basicTests. The version is
>flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is:
>'NewDPIBuckets'.
>
>Anyone has any advice?
>
>================================================
>basictests:
> [mxmlc] Loading configuration file
>C:\p\flex_os\workspace\flexroot\git\flex-
>sdk\frameworks\flex-config.xml
> [mxmlc] Loading configuration file
>C:\p\flex_os\workspace\flexroot\git\flex-
>sdk\frameworks\tests\basicTests\BasicTests-config.xml
> [mxmlc]
>C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>ests\BasicTests.swf (3723680 bytes)
> [mxmlc] Loading configuration file
>C:\p\flex_os\workspace\flexroot\git\flex-
>sdk\frameworks\flex-config.xml
> [mxmlc]
>C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>ests\basicLoader.swf (956 bytes)
> [mxmlc] Loading configuration file
>C:\p\flex_os\workspace\flexroot\git\flex-
>sdk\frameworks\flex-config.xml
> [mxmlc]
>C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>ests\spark\views\StyleManagerModuleTest.swf (517379 bytes)
> [mxmlc] Loading configuration file
>C:\p\flex_os\workspace\flexroot\git\flex-
>sdk\frameworks\flex-config.xml
> [mxmlc] Required RSLs:
> [mxmlc] framework_0.swf
> [mxmlc] textLayout_0.swf
> [mxmlc] spark_0.swf
> [mxmlc] osmf_0.swf
> [mxmlc]
>C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
>ests\spark\views\HelloWorld.swf (49207 bytes)
> [echo] launching player and swf
>
>BUILD FAILED
>C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:1436: exec
>returned:
>-107
>3741819
>
>Total time: 474 minutes 38 seconds
>================================================
>
>Thanks,
>Om
>
>
>On Sun, Aug 18, 2013 at 9:57 AM, OmPrakash Muppirala
><bi...@gmail.com>wrote:
>
>> Will do. Thanks!
>>
>>
>> On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean
>><ju...@classsoftware.com>wrote:
>>
>>> Hi,
>>>
>>> I've just checked in the ones you missed - can you fix so that they are
>>> 120 dpi?
>>>
>>> Thanks,
>>> Justin
>>
>>
>>
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I am done creating the new skins for both 120 and 640 dpi. But when I do a
release build, I am see that my Flash Player debugger freezes when running
the basicTests. The version is
flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is:
'NewDPIBuckets'.
Anyone has any advice?
================================================
basictests:
[mxmlc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\flex-config.xml
[mxmlc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\tests\basicTests\BasicTests-config.xml
[mxmlc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
ests\BasicTests.swf (3723680 bytes)
[mxmlc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\flex-config.xml
[mxmlc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
ests\basicLoader.swf (956 bytes)
[mxmlc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\flex-config.xml
[mxmlc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
ests\spark\views\StyleManagerModuleTest.swf (517379 bytes)
[mxmlc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\flex-config.xml
[mxmlc] Required RSLs:
[mxmlc] framework_0.swf
[mxmlc] textLayout_0.swf
[mxmlc] spark_0.swf
[mxmlc] osmf_0.swf
[mxmlc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\tests\basicT
ests\spark\views\HelloWorld.swf (49207 bytes)
[echo] launching player and swf
BUILD FAILED
C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:1436: exec returned:
-107
3741819
Total time: 474 minutes 38 seconds
================================================
Thanks,
Om
On Sun, Aug 18, 2013 at 9:57 AM, OmPrakash Muppirala
<bi...@gmail.com>wrote:
> Will do. Thanks!
>
>
> On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean <ju...@classsoftware.com>wrote:
>
>> Hi,
>>
>> I've just checked in the ones you missed - can you fix so that they are
>> 120 dpi?
>>
>> Thanks,
>> Justin
>
>
>
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Will do. Thanks!
On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> I've just checked in the ones you missed - can you fix so that they are
> 120 dpi?
>
> Thanks,
> Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I've just checked in the ones you missed - can you fix so that they are 120 dpi?
Thanks,
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I just used the assets you had copied over.
Here is the assumption I made based on your commit comments.
120 dpi is based off of 240 (*0.5)
640 dpi is based off of 320 (*2)
Thanks,
Om
On Tue, Aug 13, 2013 at 4:02 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > Not sure if I missed some skins during the conversion. Justin, can you
> > please take a look?
>
> Yep looks that way. Which dpi did you base the 120 and 640 off? The code
> changes I made assumed 320 as it contains extra skins then 240 and that
> makes it also in line with 480.
>
> Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Not sure if I missed some skins during the conversion. Justin, can you
> please take a look?
Yep looks that way. Which dpi did you base the 120 and 640 off? The code changes I made assumed 320 as it contains extra skins then 240 and that makes it also in line with 480.
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I tried building the NewDPIBuckets branch and am getting the following
build errors:
Not sure if I missed some skins during the conversion. Justin, can you
please take a look?
==========================
mobilecomponents:
bundles-clean:
clean:
configModLinux:
configModOther:
compile:
[echo] Compiling frameworks/libs/mobile/mobilecomponents.swc
[echo] Using C:\Program Files (x86)\Adobe\Adobe Flash Builder
4.6\sdks\Apac
heFlex4.9.0/frameworks/libs/air/airglobal.swc
[compc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\projects\mobilecomponents\compile-config.xml
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\libs\mobile\
mobilecomponents.swc (184355 bytes)
main:
[echo] Compiling frameworks/locale/en_US/mobilecomponents_rb.swc
[compc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\projects\mobilecomponents\bundle-config.xml
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\locale\en_US
\mobilecomponents_rb.swc (2684 bytes)
mobiletheme:
clean:
configModLinux:
configModOther:
compile:
[echo] Compiling frameworks/themes/Mobile/mobile.swc
[compc] Loading configuration file
C:\p\flex_os\workspace\flexroot\git\flex-
sdk\frameworks\projects\mobiletheme\compile-config.xml
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mob
iletheme\src\spark\skins\mobile\ViewMenuItemSkin.as(140): col: 49 Error:
Access
of undefined property ViewMenuItem_up in package
spark.skins.mobile120.assets.
[compc]
[compc] upBorderSkin =
spark.skins.mobile120.ass
ets.ViewMenuItem_up;
[compc]
^
[compc]
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mob
iletheme\src\spark\skins\mobile\ViewMenuItemSkin.as(141): col: 51 Error:
Access
of undefined property ViewMenuItem_down in package
spark.skins.mobile120.assets.
[compc]
[compc] downBorderSkin =
spark.skins.mobile120.a
ssets.ViewMenuItem_down;
[compc]
^
[compc]
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mob
iletheme\src\spark\skins\mobile\ViewMenuItemSkin.as(142): col: 57 Error:
Access
of undefined property ViewMenuItem_showsCaret in package
spark.skins.mobile120.a
ssets.
[compc]
[compc] showsCaretBorderSkin =
spark.skins.mobil
e120.assets.ViewMenuItem_showsCaret;
[compc]
^
[compc]
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mob
iletheme\src\spark\skins\mobile\ViewMenuItemSkin.as(32): col: 36 Error:
Definiti
on spark.skins.mobile120.assets:ViewMenuItem_down could not be found.
[compc]
[compc] import spark.skins.mobile120.assets.ViewMenuItem_down;
[compc] ^
[compc]
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mob
iletheme\src\spark\skins\mobile\ViewMenuItemSkin.as(33): col: 36 Error:
Definiti
on spark.skins.mobile120.assets:ViewMenuItem_showsCaret could not be found.
[compc]
[compc] import spark.skins.mobile120.assets.ViewMenuItem_showsCaret;
[compc] ^
[compc]
[compc]
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mob
iletheme\src\spark\skins\mobile\ViewMenuItemSkin.as(34): col: 36 Error:
Definiti
on spark.skins.mobile120.assets:ViewMenuItem_up could not be found.
[compc]
[compc] import spark.skins.mobile120.assets.ViewMenuItem_up;
[compc] ^
[compc]
BUILD FAILED
C:\p\flex_os\workspace\flexroot\git\flex-sdk\build.xml:416: The following
error
occurred while executing this line:
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\build.xml:124: The
follo
wing error occurred while executing this line:
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\build.xml:359: The
follo
wing error occurred while executing this line:
C:\p\flex_os\workspace\flexroot\git\flex-sdk\frameworks\projects\mobiletheme\bui
ld.xml:85: compc task failed.
Total time: 45 minutes 49 seconds
==========================
On Sun, Aug 11, 2013 at 11:01 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
> On 8/11/13 6:25 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> >Hi,
> >
> >Tests are done and check into the NewDPIBuckets branch and all pass.
> >
> >If someone could review that would be great as I'm not 100% sure the
> >scaling tests are actually working.
> I'm not clear that mustella will run the mobile tests in anything other
> than Android@240 dpi. But I could be wrong...
> -Alex
>
>
Re: 120 and 640 dpi support
Posted by Alex Harui <ah...@adobe.com>.
On 8/11/13 6:25 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>Tests are done and check into the NewDPIBuckets branch and all pass.
>
>If someone could review that would be great as I'm not 100% sure the
>scaling tests are actually working.
I'm not clear that mustella will run the mobile tests in anything other
than Android@240 dpi. But I could be wrong...
-Alex
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Tests are done and check into the NewDPIBuckets branch and all pass.
If someone could review that would be great as I'm not 100% sure the scaling tests are actually working.
For instance in applictaionDPI_120 I'd expect some failure due to rounding errors.
<AssertPropertyValue target="" propertyName="scalingFactor" value="1" >
<ConditionalValue deviceDensity="120" value="1"/>
<ConditionalValue deviceDensity="160" value="1.33333"/>
<ConditionalValue deviceDensity="240" value="2"/>
<ConditionalValue deviceDensity="320" value="2.66667"/>
<ConditionalValue deviceDensity="480" value="4"/>
<ConditionalValue deviceDensity="640" value="5.33333"/>
</AssertPropertyValue>
Thanks,
Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Mostly, my laziness :-) I have too many things going on right now - so
> building manually from the branch would be disruptive.
Took me about 10 min and 8 min of that was waiting for it to build while I did something else. :-)
You can always have more than one tree/more than one SDK set up as I'm sure you know.
Thanks,
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Sun, Aug 11, 2013 at 9:46 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > Any plans to merge it into develop so I can just get the nightly build
> and
> > test it?
> We should really only merge after it's been completed/tested.
>
>
Agreed.
> > I am trying to avoid building the sdk on the branch if possible.
> Any particular reason why? I thought the whole point with changes like
> this is that they needed to go into a feature branch.
>
Mostly, my laziness :-) I have too many things going on right now - so
building manually from the branch would be disruptive.
Never mind, I will find some time to test my mobile apps from branch soon.
Thanks,
Om
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Any plans to merge it into develop so I can just get the nightly build and
> test it?
We should really only merge after it's been completed/tested.
> I am trying to avoid building the sdk on the branch if possible.
Any particular reason why? I thought the whole point with changes like this is that they needed to go into a feature branch.
Thanks,
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Sun, Aug 11, 2013 at 6:09 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > I've checked in the skins for the 120dpi and 640dpi themes. Anything
> else
> > I can help with?
>
> Sure if you can try out the 160 and 640 dpi skins on some existing mobile
> projects you have and see what they look like.
>
> I'll get the mobile tests working.
>
>
Any plans to merge it into develop so I can just get the nightly build and
test it? I am trying to avoid building the sdk on the branch if possible.
Thanks,
Om
> Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I've checked in the skins for the 120dpi and 640dpi themes. Anything else
> I can help with?
Sure if you can try out the 160 and 640 dpi skins on some existing mobile projects you have and see what they look like.
I'll get the mobile tests working.
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I've checked in the skins for the 120dpi and 640dpi themes. Anything else
I can help with?
Thanks,
Om
On Fri, Aug 9, 2013 at 11:52 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> And also changes required in the CSS in the mobile theme default.css.
>
> Justin
>
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
And also changes required in the CSS in the mobile theme default.css.
Justin
Re: 120 and 640 dpi support
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I see the changes you made in the new branch. Is resizing the fxg files
the only thing remaining?
I have seen some developers observe that using 160 dpi skins and letting it
scale up improves the performance of mobile apps. This makes sense because
the higher the dpi increases, the FXG files seems to be having more and
more objects.
So, for the 640 dpi skins, it makes sense to take the 160 dpi skins and
quadruple the scale for each element in the FXG. This guarantees best
performance.
Anyone has thoughts/suggestions on this approach?
Thanks,
Om
On Fri, Aug 9, 2013 at 10:44 AM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > Please assign the 120 and 640 dpi JIRA tickets to me. I will have some
> > bandwidth to work on them in the next week.
> Already started - there's a NewDPIBucket branch, I'll check it in and you
> can take over if you want.
>
> It actually simpler than the 480 as the 640 is just double the 320 (so you
> may want to clean up first) and 120 half of 240.
>
> If you need a hand just say so.
>
> Thanks,
> Justin
Re: 120 and 640 dpi support
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Please assign the 120 and 640 dpi JIRA tickets to me. I will have some
> bandwidth to work on them in the next week.
Already started - there's a NewDPIBucket branch, I'll check it in and you can take over if you want.
It actually simpler than the 480 as the 640 is just double the 320 (so you may want to clean up first) and 120 half of 240.
If you need a hand just say so.
Thanks,
Justin