You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/16 12:25:49 UTC
[GitHub] [arrow-rs] ilya-biryukov opened a new pull request #781: fix: nanosecond timestamp scaling during string conversion (#780)
ilya-biryukov opened a new pull request #781:
URL: https://github.com/apache/arrow-rs/pull/781
Some datetime formats passed to `string_to_timestamp_nanos` were parsing
milliseconds as nanoseconds.
E.g. `1970-01-01 00:00:00.123` would parse as `123` nanoseconds instead
of milliseconds.
# Which issue does this PR close?
Closes #780.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #781: fix: nanosecond timestamp scaling during string conversion (#780)
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #781:
URL: https://github.com/apache/arrow-rs/pull/781#issuecomment-921883888
Wow, that's a big foot-gun in chrono. Fix looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #781: fix: nanosecond timestamp scaling during string conversion (#780)
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #781:
URL: https://github.com/apache/arrow-rs/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ilya-biryukov commented on pull request #781: fix: nanosecond timestamp scaling during string conversion (#780)
Posted by GitBox <gi...@apache.org>.
ilya-biryukov commented on pull request #781:
URL: https://github.com/apache/arrow-rs/pull/781#issuecomment-921862783
Was also surprised how deceitfully similar the formats are. We happened to pre-parse the format strings (for performance, this function is on hot path in CubeStore) and the difference is [easy to spot](https://github.com/cube-js/arrow-rs/commit/0293429456f4464c7065075d909dce4269e477c4?branch=0293429456f4464c7065075d909dce4269e477c4&diff=unified#diff-2e91ef6c992ac2ad5db111bda8eb9fdb056a7849df85ba378d39f47a00a85704L156) there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #781: fix: nanosecond timestamp scaling during string conversion (#780)
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #781:
URL: https://github.com/apache/arrow-rs/pull/781#discussion_r710512561
##########
File path: arrow/src/compute/kernels/cast_utils.rs
##########
@@ -227,7 +227,7 @@ mod tests {
// somewhat suceptable to bugs in the use of chrono
let naive_datetime = NaiveDateTime::new(
NaiveDate::from_ymd(2020, 9, 8),
- NaiveTime::from_hms_nano(13, 42, 29, 190855),
+ NaiveTime::from_hms_nano(13, 42, 29, 190855000),
Review comment:
This is a compelling bug in the test that is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #781: fix: nanosecond timestamp scaling during string conversion (#780)
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #781:
URL: https://github.com/apache/arrow-rs/pull/781#issuecomment-921913165
Thanks @ilya-biryukov and @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org