You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/09 19:13:55 UTC
Review Request 13443: Changed slave state recovery to ignore absence of
files as safe.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13443/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-634
https://issues.apache.org/jira/browse/MESOS-634
Repository: mesos-git
Description
-------
We moved absence of files from strictness checking, because it is expected behavior in normal course of action.
Diffs
-----
src/slave/state.cpp 77b29dc80b100e63504c8729380c5deadcab0dd3
Diff: https://reviews.apache.org/r/13443/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13443: Changed slave state recovery to ignore absence of
files as safe.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13443/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 10:45 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Bugs: MESOS-634
https://issues.apache.org/jira/browse/MESOS-634
Repository: mesos-git
Description
-------
We moved absence of files from strictness checking, because it is expected behavior in normal course of action.
Diffs (updated)
-----
src/slave/state.cpp 77b29dc80b100e63504c8729380c5deadcab0dd3
Diff: https://reviews.apache.org/r/13443/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13443: Changed slave state recovery to ignore absence of
files as safe.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13443/#review25073
-----------------------------------------------------------
Ship it!
Can you add a comment over each case you've added here? The meaning of each case is not immediately obvious to me, so adding the comments would be useful for myself and others when reading the code and trying to understand what it means for each file to be missing.
e.g.
// If the SlaveInfo file is missing, this means the slave died before it could register with the master.
// If the FrameworkInfo file is missing, ...
// If the executor libprocess pid is missing, this means the slave died before the executor driver connected with the slave.
...
Please and thanks!
- Ben Mahler
On Aug. 9, 2013, 5:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13443/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-634
> https://issues.apache.org/jira/browse/MESOS-634
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We moved absence of files from strictness checking, because it is expected behavior in normal course of action.
>
>
> Diffs
> -----
>
> src/slave/state.cpp 77b29dc80b100e63504c8729380c5deadcab0dd3
>
> Diff: https://reviews.apache.org/r/13443/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>