You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:19:37 UTC
[GitHub] [carbondata] maheshrajus opened a new pull request #4154: [WIP] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
maheshrajus opened a new pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154
### Why is this PR needed?
need to update
### What changes were proposed in this PR?
need to update
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-866274125
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3866/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865263423
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3852/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865897498
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865688776
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865902221
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5605/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865174886
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865267125
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864792736
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3842/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#discussion_r655211805
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,39 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("drop table if exists time_parquet")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("create table if not exists time_parquet(time1 timestamp) stored as parquet")
+ sql("insert into time_carbon1 select from_unixtime(0)")
+ sql("insert into time_parquet select from_unixtime(0)")
+ checkAnswer(sql("select * from time_carbon1"),
+ sql("select * from time_parquet"))
+ checkAnswer(sql("select count(*) from time_carbon1"), Seq(Row(1)))
+ checkAnswer(sql("select * from time_carbon1"),
Review comment:
it is sufficient to check answer with parquet table itslef. you can remove this checkanswer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864787145
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5585/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865128265
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-866269598
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5611/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865791536
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#discussion_r654193200
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,21 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("insert into time_carbon1 select from_unixtime(0)")
Review comment:
insert into table select '', results should be NULL. After this change, it is inserting default time. Please check
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CommonLoadUtils.scala
##########
@@ -781,9 +781,8 @@ object CommonLoadUtils {
internalRowOriginal
}
for (index <- timeStampIndex) {
- if (internalRow.getLong(index) == 0) {
- internalRow.setNullAt(index)
- } else {
+ // if value zero case spark will fill the timestamp. no need to fill null
Review comment:
Should Check, internalRow.isNullAt(index) , for actual null or empty data. then insert null for that row
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,21 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("insert into time_carbon1 select from_unixtime(0)")
Review comment:
insert into table select '', results should be NULL. After this change, it is inserting default time. Please check and add a insert sql in this testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a change in pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on a change in pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#discussion_r654374684
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,21 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("insert into time_carbon1 select from_unixtime(0)")
Review comment:
ok
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CommonLoadUtils.scala
##########
@@ -781,9 +781,8 @@ object CommonLoadUtils {
internalRowOriginal
}
for (index <- timeStampIndex) {
- if (internalRow.getLong(index) == 0) {
- internalRow.setNullAt(index)
- } else {
+ // if value zero case spark will fill the timestamp. no need to fill null
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864894115
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3843/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864787145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a change in pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on a change in pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#discussion_r655241321
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,39 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("drop table if exists time_parquet")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("create table if not exists time_parquet(time1 timestamp) stored as parquet")
+ sql("insert into time_carbon1 select from_unixtime(0)")
+ sql("insert into time_parquet select from_unixtime(0)")
+ checkAnswer(sql("select * from time_carbon1"),
+ sql("select * from time_parquet"))
+ checkAnswer(sql("select count(*) from time_carbon1"), Seq(Row(1)))
+ checkAnswer(sql("select * from time_carbon1"),
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865781643
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865029142
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865018293
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3847/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865029142
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865023839
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5590/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a change in pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on a change in pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#discussion_r655241321
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,39 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("drop table if exists time_parquet")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("create table if not exists time_parquet(time1 timestamp) stored as parquet")
+ sql("insert into time_carbon1 select from_unixtime(0)")
+ sql("insert into time_parquet select from_unixtime(0)")
+ checkAnswer(sql("select * from time_carbon1"),
+ sql("select * from time_parquet"))
+ checkAnswer(sql("select count(*) from time_carbon1"), Seq(Row(1)))
+ checkAnswer(sql("select * from time_carbon1"),
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865607680
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [WIP] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-863572797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864010719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865132993
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5594/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864891842
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-865174886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#discussion_r655211805
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCase.scala
##########
@@ -73,6 +75,39 @@ class AllDataTypesTestCase extends QueryTest with BeforeAndAfterAll {
}
}
+ test("insert data with from_unixtime(0) and query") {
+ sql("drop table if exists time_carbon1")
+ sql("drop table if exists time_parquet")
+ sql("create table if not exists time_carbon1(time1 timestamp) stored as carbondata")
+ sql("create table if not exists time_parquet(time1 timestamp) stored as parquet")
+ sql("insert into time_carbon1 select from_unixtime(0)")
+ sql("insert into time_parquet select from_unixtime(0)")
+ checkAnswer(sql("select * from time_carbon1"),
+ sql("select * from time_parquet"))
+ checkAnswer(sql("select count(*) from time_carbon1"), Seq(Row(1)))
+ checkAnswer(sql("select * from time_carbon1"),
Review comment:
it is sufficient to check answer with parquet table itslef. you can remove this checkanswer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-866169118
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4154: [CARBONDATA-4214] inserting NULL value when timestamp value received from FROM_UNIXTIME(0)
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4154:
URL: https://github.com/apache/carbondata/pull/4154#issuecomment-864728746
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org