You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/11 13:29:49 UTC
[GitHub] [maven-surefire] liry opened a new pull request, #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
liry opened a new pull request, #570:
URL: https://github.com/apache/maven-surefire/pull/570
Surefire is using `surefire.failIfNoSpecifiedTests`, but failsafe used `it.failIfNoSpecifiedTests`.
Error msg is then pointed to nonexistent property: `No tests matching pattern "..." were executed! (Set -Dfailsafe.failIfNoSpecifiedTests=false to ignore this error.)`
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] liry commented on pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
Posted by GitBox <gi...@apache.org>.
liry commented on PR #570:
URL: https://github.com/apache/maven-surefire/pull/570#issuecomment-1274692172
Not sure if the parameter deprecation can work this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a diff in pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
Posted by "andpab (via GitHub)" <gi...@apache.org>.
andpab commented on code in PR #570:
URL: https://github.com/apache/maven-surefire/pull/570#discussion_r1109517648
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -130,12 +130,24 @@
private boolean useFile;
/**
- * Set this to "true" to cause a failure if none of the tests specified in -Dtest=... are run. Defaults to
+ * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
* "true".
*
* @since 2.12
+ * @deprecated Since 3.0.0-M8, use "failsafe.failIfNoSpecifiedTests" instead.
*/
+ @Deprecated
@Parameter( property = "it.failIfNoSpecifiedTests", defaultValue = "true" )
+ private boolean failIfNoSpecifiedTestsDeprecated;
+
+ /**
+ * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
+ * "true".
+ * Replacing "it.failIfNoSpecifiedTests" to be consistent with surefire plugin.
Review Comment:
I agree with your suggestion, but @liry did not change the wording here.
Since there's no response from @liry, can the PR be merged anyway? In my fork I've rebased the branch to master. Builds were successful: https://github.com/andpab/maven-surefire/actions/runs/4198008135
After the merge of this one I could make a new PR that adjusts the wording according to your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] liry commented on a diff in pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
Posted by "liry (via GitHub)" <gi...@apache.org>.
liry commented on code in PR #570:
URL: https://github.com/apache/maven-surefire/pull/570#discussion_r1112364956
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -130,12 +130,24 @@
private boolean useFile;
/**
- * Set this to "true" to cause a failure if none of the tests specified in -Dtest=... are run. Defaults to
+ * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
* "true".
*
* @since 2.12
+ * @deprecated Since 3.0.0-M8, use "failsafe.failIfNoSpecifiedTests" instead.
*/
+ @Deprecated
@Parameter( property = "it.failIfNoSpecifiedTests", defaultValue = "true" )
+ private boolean failIfNoSpecifiedTestsDeprecated;
+
+ /**
+ * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
+ * "true".
+ * Replacing "it.failIfNoSpecifiedTests" to be consistent with surefire plugin.
Review Comment:
Sorry, I somehow missed the first comment. Wording changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #570:
URL: https://github.com/apache/maven-surefire/pull/570#discussion_r1055259627
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -130,12 +130,24 @@
private boolean useFile;
/**
- * Set this to "true" to cause a failure if none of the tests specified in -Dtest=... are run. Defaults to
+ * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
* "true".
*
* @since 2.12
+ * @deprecated Since 3.0.0-M8, use "failsafe.failIfNoSpecifiedTests" instead.
*/
+ @Deprecated
@Parameter( property = "it.failIfNoSpecifiedTests", defaultValue = "true" )
+ private boolean failIfNoSpecifiedTestsDeprecated;
+
+ /**
+ * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
+ * "true".
+ * Replacing "it.failIfNoSpecifiedTests" to be consistent with surefire plugin.
Review Comment:
as `true` is the default value, I would start documentation from something like
> Set this to false to prevent a failure if none ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #570:
URL: https://github.com/apache/maven-surefire/pull/570#discussion_r1112608175
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -899,9 +911,16 @@ public void setSystemPropertiesFile( File systemPropertiesFile )
}
@Override
+ @SuppressWarnings( "deprecation" )
public boolean getFailIfNoSpecifiedTests()
{
- return failIfNoSpecifiedTests;
+ if ( !failIfNoSpecifiedTestsDeprecated )
+ {
+ getConsoleLogger().warning( "Use " + getPluginName()
+ + ".failIfNoSpecifiedTests property instead of obsolete it.failIfNoSpecifiedTests." );
Review Comment:
Maven 3.9 will print such info itself - but can be now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #570:
URL: https://github.com/apache/maven-surefire/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org