You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/03/17 10:18:10 UTC
[GitHub] [incubator-opendal] suyanhanx opened a new pull request, #1664: Add index dts
suyanhanx opened a new pull request, #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664
Patch `napi-cli` to append license header into `index.d.ts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1664: feat(bindings/nodejs): Add generated `index.d.ts`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664#discussion_r1140046048
##########
bindings/nodejs/.yarn/patches/@napi-rs-cli-npm-2.14.8-71492d0ade.patch:
##########
Review Comment:
:face_with_spiral_eyes: :face_with_spiral_eyes: :face_with_spiral_eyes:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #1664: feat(bindings/nodejs): Add generated `index.d.ts`
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664#discussion_r1140053687
##########
bindings/nodejs/.yarn/patches/@napi-rs-cli-npm-2.14.8-71492d0ade.patch:
##########
Review Comment:
As an important dependency of this binding, `napi-rs` has now entered a stable version period and we do not need to update it frequently. Therefore, I directly patched it to achieve the part we needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #1664: feat(bindings/nodejs): Add generated `index.d.ts`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1664: feat(bindings/nodejs): Add generated `index.d.ts`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664#discussion_r1140060959
##########
bindings/nodejs/.yarn/patches/@napi-rs-cli-npm-2.14.8-71492d0ade.patch:
##########
Review Comment:
Submitted as an issue: https://github.com/napi-rs/napi-rs/issues/1523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1664: feat(bindings/nodejs): Add generated `index.d.ts`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664#discussion_r1140058667
##########
bindings/nodejs/.yarn/patches/@napi-rs-cli-npm-2.14.8-71492d0ade.patch:
##########
Review Comment:
We require assistance from upstream.
The logic involved appears to be relatively simple.
Here is the link to the relevant code: https://github.com/napi-rs/napi-rs/blob/347e81b3cc5563bdee0d9f15a3489cc571c3e0f1/cli/src/build.ts#L665-L669
Would you consider accepting a pull request that adds support for custom headers? cc @Brooooooklyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1664: feat(bindings/nodejs): Add generated `index.d.ts`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1664:
URL: https://github.com/apache/incubator-opendal/pull/1664#issuecomment-1473615910
Please merge the `main` branch with your current branch as we have enabled the license checker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org