[GitHub] [superset] TColl removed a comment on pull request #12806: refactor: speed up conversion from dataframe to list of records

[GitBox <gi...@apache.org>]

TColl removed a comment on pull request #12806:
URL: https://github.com/apache/superset/pull/12806#issuecomment-773988790


   I've had another look at this, and dropping pandas `DataFrame.to_dict()` in favour of the underlying operation means we can do the integer conversion during the same single loop over all records in the dataframe, rather than looping over the whole dataframe twice to get to where we need to end up.
   
   At the risk of making myself look stupid, this seems to result in a 2x speedup on my local tests this time round, but I'd appreciate a second pair of eyes on this!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org