You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "senn (via GitHub)" <gi...@apache.org> on 2024/09/02 08:21:02 UTC

[PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]

senn opened a new pull request, #42:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42

   Some code improvements suggested by Sonar in original PR #41 + fixed some (some-what related) warnings my IDE pointed out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]

Posted by "senn (via GitHub)" <gi...@apache.org>.
senn commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324475939

   The sonarcloud issues are because I fixed a typo in an exception message, so it asks for a constant.  Don't think that's crucial here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert merged PR #42:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324426075

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=42) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [D Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=42) (required ≥ A)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=42)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]

Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324659439

   > The sonarcloud issues are because I fixed a typo in an exception message, so it asks for a constant. Don't think that's crucial here.
   
   thanks, lgtm. not sure why those warnings relating to the RuntimeException and it's messages are reported as new issues here - they were present before already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] SLING-12413: update/improve code [sling-org-apache-sling-testing-osgi-mock]

Posted by "senn (via GitHub)" <gi...@apache.org>.
senn commented on PR #42:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/42#issuecomment-2324115017

   @stefanseifert anything else you'd like to see updated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org