You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/21 05:31:00 UTC
[jira] [Work logged] (HIVE-26396) The trunc function has a problem with precision interception and the result has many 0
[ https://issues.apache.org/jira/browse/HIVE-26396?focusedWorklogId=793541&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793541 ]
ASF GitHub Bot logged work on HIVE-26396:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/22 05:30
Start Date: 21/Jul/22 05:30
Worklog Time Spent: 10m
Work Description: simhadri-g opened a new pull request, #3463:
URL: https://github.com/apache/hive/pull/3463
… decimal data type.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
The truncate UDF returns incorrect output for constant decimal datatypes.
Ex:
SELECT trunc(1234567891.1234567891,4), trunc(1234567891.1234567891,-4), trunc(1234567891.1234567891,0), trunc(1234567891.1234567891) FROM src tablesample (1 rows)
Returns incorrect output:
1234567891.123400000000000000 1234560000.000000000000000000 1234567891.000000000000000000 1234567891.000000000000000000
Whereas the correct output of the truncate function should be:
1234567891.1234 1234560000 1234567891 1234567891
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the output of the truncate udf changes.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
With q files and manual tests.
Issue Time Tracking
-------------------
Worklog Id: (was: 793541)
Remaining Estimate: 0h
Time Spent: 10m
> The trunc function has a problem with precision interception and the result has many 0
> --------------------------------------------------------------------------------------
>
> Key: HIVE-26396
> URL: https://issues.apache.org/jira/browse/HIVE-26396
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.1.3
> Environment: CDP7.1.7 ,RedHat7.6
> Reporter: phZhou
> Assignee: Simhadri G
> Priority: Blocker
> Fix For: 3.2.0, 4.0.0, 4.0.0-alpha-2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The trunc function has a problem with precision interception and the result has many 0，There is a problem with the return when the data is of decimal type, and it is displayed normally when the data is of double type。The test is as follows:
> 1：Execute on beeline：
> SELECT trunc(15.8963,3);
> +------------------------+
> | _c0 |
> +------------------------+
> | 15.896000000000000000 |
> +------------------------+
> 1 row selected (0.074 seconds)
> need return “15.896”is correct。
--
This message was sent by Atlassian Jira
(v8.20.10#820010)