You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/05/14 22:32:51 UTC

[GitHub] [phoenix] kadirozde commented on a change in pull request #779: PHOENIX-5896: Implement incremental rebuild along the failed regions …

kadirozde commented on a change in pull request #779:
URL: https://github.com/apache/phoenix/pull/779#discussion_r425467457



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -1191,6 +1203,9 @@ public boolean next(List<Cell> results) throws IOException {
         }
         Cell lastCell = null;
         int rowCount = 0;
+        if(!shouldRebuildOrVerify()) {

Review comment:
       Have we decided that we would do this check always? Should we do this only when incremental build is specified? At least we should do this check for read-repair since it will unnecessarily impact the read performance.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org