You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/04 09:59:48 UTC

[GitHub] [skywalking] BFergerson edited a comment on pull request #5085: Include request method type in rest mapping annotations

BFergerson edited a comment on pull request #5085:
URL: https://github.com/apache/skywalking/pull/5085#issuecomment-675112178


   I'm not able to successfully run e2e tests locally.
   
   I'm running:
   ```sh
   git clone --recurse-submodules https://github.com/apache/skywalking.git
   cd skywalking/
   export SW_STORAGE=h2 && export SW_AGENT_JDK_VERSION=8 && export SKIP_TEST=true
   make docker && ES_VERSION=es7 TAG=latest-es7 make docker.oap
   cp -R dist test/e2e/
   ./mvnw --batch-mode -f test/e2e/pom.xml -am -DfailIfNoTests=false verify -Dit.test=org.apache.skywalking.e2e.profile.ProfileE2E
   ```
   
   And I'm getting:
   ```
   00:54:46.641 INFO  o.a.s.e2e.SkyWalkingAnnotations.<clinit> (108) - IDENTIFIER=skywalking-e2e-
   00:54:46.644 INFO  o.a.s.e2e.SkyWalkingAnnotations.<clinit> (109) - LOG_DIR=/tmp/skywalking/logs
   00:54:46.736 INFO  o.t.d.DockerClientProviderStrategy.lambda$getFirstValidStrategy$1 (110) - Loaded org.testcontainers.dockerclient.EnvironmentAndSystemPropertyClientProviderStrategy from ~/.testcontainers.properties, will try it first
   00:54:47.051 INFO  o.t.d.EnvironmentAndSystemPropertyClientProviderStrategy.test (47) - Found docker client settings from environment
   00:54:47.051 INFO  o.t.d.DockerClientProviderStrategy.lambda$getFirstValidStrategy$2 (119) - Found Docker environment with Environment variables, system properties and defaults. Resolved dockerHost=unix:///var/run/docker.sock
   00:54:47.169 INFO  o.testcontainers.DockerClientFactory.client (137) - Docker host IP address is localhost
   00:54:47.189 INFO  o.testcontainers.DockerClientFactory.client (144) - Connected to docker: 
     Server Version: 19.03.8
     API Version: 1.40
     Operating System: Ubuntu 20.04.1 LTS
     Total Memory: 31742 MB
   00:54:48.378 WARN  o.t.utility.RegistryAuthLocator.lookupAuthConfig (135) - Failure when attempting to lookup auth config (dockerImageName: quay.io/testcontainers/ryuk:0.2.3, configFile: /home/brandon/.docker/config.json. Falling back to docker-java default behaviour. Exception message: /home/brandon/.docker/config.json (No such file or directory)
   00:54:48.875 INFO  o.testcontainers.DockerClientFactory.client (156) - Ryuk started - will monitor and terminate Testcontainers containers on JVM exit
   00:54:48.875 INFO  o.testcontainers.DockerClientFactory.client (167) - Checking the system...
   00:54:48.876 INFO  o.testcontainers.DockerClientFactory.check (224) - ✔︎ Docker server version should be at least 1.6.0
   00:54:48.973 INFO  o.testcontainers.DockerClientFactory.check (224) - ✔︎ Docker environment should have more than 2GB free disk space
   00:54:49.443 INFO  o.a.s.e2e.SkyWalkingAnnotations.lambda$initDockerComposeField$2 (210) - /home/brandon/Desktop/test/skywalking/test/e2e/e2e-test/docker/profile/docker-compose.yml
   [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.067 s <<< FAILURE! - in org.apache.skywalking.e2e.profile.ProfileE2E
   [ERROR] org.apache.skywalking.e2e.profile.ProfileE2E  Time elapsed: 3.066 s  <<< ERROR!
   java.lang.NullPointerException
   
   [INFO] 
   [INFO] Results:
   [INFO] 
   [ERROR] Errors: 
   [ERROR]   ProfileE2E » NullPointer
   [INFO] 
   [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
   [INFO] 
   [INFO] 
   [INFO] --- maven-failsafe-plugin:2.22.0:verify (default) @ e2e-test ---
   [INFO] ------------------------------------------------------------------------
   [INFO] Reactor Summary for SkyWalking End to End Tests 1.0.0:
   [INFO] 
   [INFO] SkyWalking End to End Tests ........................ SUCCESS [  1.360 s]
   [INFO] e2e-common ......................................... SUCCESS [ 11.244 s]
   [INFO] e2e-base ........................................... SUCCESS [  3.856 s]
   [INFO] e2e-protocol ....................................... SUCCESS [  2.986 s]
   [INFO] e2e-service-provider ............................... SUCCESS [  0.948 s]
   [INFO] e2e-service-consumer ............................... SUCCESS [  0.541 s]
   [INFO] e2e-test ........................................... FAILURE [  6.124 s]
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  27.377 s
   [INFO] Finished at: 2020-08-18T00:54:50+04:00
   [INFO] ------------------------------------------------------------------------
   ```
   
   When I run ProfileE2E directly I get:
   ```sh
   java.lang.NullPointerException
   	at org.apache.skywalking.e2e.SkyWalkingAnnotations.lambda$initDockerComposeField$2(SkyWalkingAnnotations.java:211)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
   	at org.apache.skywalking.e2e.SkyWalkingAnnotations.initDockerComposeField(SkyWalkingAnnotations.java:206)
   	at org.apache.skywalking.e2e.SkyWalkingAnnotations.init(SkyWalkingAnnotations.java:115)
   	at org.apache.skywalking.e2e.SkyWalkingExtension.beforeAll(SkyWalkingExtension.java:53)
   	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$7(ClassBasedTestDescriptor.java:355)
   	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:355)
   	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:189)
   	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:77)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:132)
   	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
   	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
   	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
   	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
   	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
   	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
   	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
   	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
   	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
   	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
   	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
   	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:229)
   	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:197)
   	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:211)
   	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:191)
   	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
   	at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
   	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
   	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220)
   	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53)
   	Suppressed: java.lang.NullPointerException
   		at org.apache.skywalking.e2e.SkyWalkingAnnotations.lambda$destroy$0(SkyWalkingAnnotations.java:137)
   		at java.base/java.util.Optional.ifPresent(Optional.java:176)
   		at org.apache.skywalking.e2e.SkyWalkingAnnotations.destroy(SkyWalkingAnnotations.java:134)
   		at org.apache.skywalking.e2e.SkyWalkingExtension.afterAll(SkyWalkingExtension.java:58)
   		at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeAfterAllCallbacks$13(ClassBasedTestDescriptor.java:421)
   		at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   		at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeAfterAllCallbacks$14(ClassBasedTestDescriptor.java:421)
   		at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
   		at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeAfterAllCallbacks(ClassBasedTestDescriptor.java:421)
   		at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.after(ClassBasedTestDescriptor.java:213)
   		at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.after(ClassBasedTestDescriptor.java:77)
   		at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:145)
   		at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
   		at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:145)
   		... 27 more
   ```
   
   Which I think is the same NPE as when I run via `./mvnw`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org