You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/18 10:42:11 UTC
[GitHub] [shardingsphere] totalo opened a new pull request #11883: chore:add skywalking-eyes to check License.
totalo opened a new pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883
For 11876.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691280227
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
I am not sure whether can change license of `MavenWrapperDownloader`, it is not source code of ShardingSphere.
Could you contact skywalking community to confirm it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691303345
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
I found from the code of `skywalking` that this generation purchase is also licensed under this license. It seems that it cannot be changed. I will ignore the `.mvn` for now.
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
I found from the code of Skywalking that this generation purchase is also licensed under this license. It seems that it cannot be changed. I will ignore the `.mvn` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691303345
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
I found from the code of `skywalking` that this generation purchase is also licensed under this license. It seems that it cannot be changed. I will ignore the `.mvn` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wu-sheng commented on pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#issuecomment-901589703
One tip, this should be able to replace rat plugin.
FYI @kezhenxu94 @fgksgf we have progress here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691836202
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
Okay, I will fix this question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691303345
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
I found from the code of Skywalking that this generation purchase is also licensed under this license. It seems that it cannot be changed. I will ignore the `.mvn` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wu-sheng commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691755781
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
Oh, this was on their original header, even it is wrong. But we don't know what should we change to. And all things not updated after that(2+ years ago)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wu-sheng commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691756140
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
Welcome to fix this on SkyWalking site too. This was not deliberate, it is just legacy. @totalo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691280227
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
I am not sure whether can change license of `MavenWrapperDownloader`, it is not source code of ShardingSphere.
Could you contact skywalking community to confirm it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wu-sheng commented on a change in pull request #11883: Add skywalking-eyes to check License.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11883:
URL: https://github.com/apache/shardingsphere/pull/11883#discussion_r691756140
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -1,18 +1,20 @@
/*
- * Copyright 2007-present the original author or authors.
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review comment:
Welcome to fix this on SkyWalking site too. This was deliberate. @totalo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org