[jira] [Commented] (TS-4598) Coverity Null-Check after deref in NetworkUtilisRemote.cc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357787#comment-15357787 ] 

ASF GitHub Bot commented on TS-4598:
------------------------------------

GitHub user strotyl opened a pull request:

    https://github.com/apache/trafficserver/pull/775

    TS-4598 : Coverity Null-Check after deref in NetworkUtilisRemote.cc

    This is fixing Coverity issue CID 1237320.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/strotyl/trafficserver TS-4598

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #775
    
----
commit dd9d9c8ef77c9bdd31ff8fb6ce998d2ec46cc73b
Author: Tyler Stroh <ts...@apple.com>
Date:   2016-06-27T21:55:36Z

    TS-4598 : Coverity Null-Check after deref in NetworkUtilisRemote.cc
    
    This is fixing Coverity issue CID 1237320.

----


> Coverity Null-Check after deref in NetworkUtilisRemote.cc
> ---------------------------------------------------------
>
>                 Key: TS-4598
>                 URL: https://issues.apache.org/jira/browse/TS-4598
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Network
>            Reporter: Tyler Stroh
>            Assignee: Tyler Stroh
>              Labels: coverity
>             Fix For: 7.0.0
>
>
> {code}
> ** 1237320 Dereference before null check **
> ___________________________________________
> 660  event_notice = (TSMgmtEvent *)arg;
>    	deref_ptr: Directly dereferencing pointer event_notice.
> 661  index        = (int)event_notice->id;
> 662  LLQ *func_q; // list of callback functions need to call
> 663
> 664  func_q = create_queue();
> 665  if (!func_q) {
>    	
> CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
> check_after_deref: Null-checking event_notice suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
> 666    if (event_notice)
> 667      TSEventDestroy(event_notice);
> 668    return NULL;
> 669  }
>  ___________________________________________
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)