You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Deepak Barr <de...@gmail.com> on 2015/09/25 16:01:21 UTC

Review Request 38762: LENS-224 : FinishedLensQuery is not storing selectedDriver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38762/
-----------------------------------------------------------

Review request for lens.


Repository: lens


Description
-------

The selectedDriver information will be persisted in finishedquery table.


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 7a06c44 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 59b1221 

Diff: https://reviews.apache.org/r/38762/diff/


Testing
-------

Yes.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [  2.723 s]
[INFO] Lens ............................................... SUCCESS [  4.688 s]
[INFO] Lens API ........................................... SUCCESS [ 27.481 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 27.680 s]
[INFO] Lens Cube .......................................... SUCCESS [07:03 min]
[INFO] Lens DB storage .................................... SUCCESS [ 29.390 s]
[INFO] Lens Query Library ................................. SUCCESS [ 22.423 s]
[INFO] Lens Hive Driver ................................... SUCCESS [04:11 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 52.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 22.937 s]
[INFO] Lens Server ........................................ SUCCESS [11:05 min]
[INFO] Lens client ........................................ SUCCESS [ 49.578 s]
[INFO] Lens CLI ........................................... SUCCESS [03:48 min]
[INFO] Lens Examples ...................................... SUCCESS [ 12.548 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.504 s]
[INFO] Lens ML Lib ........................................ SUCCESS [02:03 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  3.647 s]
[INFO] Lens Regression .................................... SUCCESS [ 15.211 s]
[INFO] Lens UI ............................................ SUCCESS [  6.025 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:04 min
[INFO] Finished at: 2015-09-25T19:29:26+05:30
[INFO] Final Memory: 215M/2967M
[INFO] ------------------------------------------------------------------------


Thanks,

Deepak Barr


Re: Review Request 38762: LENS-224 : FinishedLensQuery is not storing selectedDriver

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38762/#review100802
-----------------------------------------------------------

Ship it!



lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java (line 237)
<https://reviews.apache.org/r/38762/#comment158044>

    add a todo regarding LENS-123


- Rajat Khandelwal


On Sept. 25, 2015, 7:31 p.m., Deepak Barr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38762/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 7:31 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> The selectedDriver information will be persisted in finishedquery table.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 7a06c44 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 59b1221 
> 
> Diff: https://reviews.apache.org/r/38762/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  2.723 s]
> [INFO] Lens ............................................... SUCCESS [  4.688 s]
> [INFO] Lens API ........................................... SUCCESS [ 27.481 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 27.680 s]
> [INFO] Lens Cube .......................................... SUCCESS [07:03 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 29.390 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 22.423 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [04:11 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 52.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 22.937 s]
> [INFO] Lens Server ........................................ SUCCESS [11:05 min]
> [INFO] Lens client ........................................ SUCCESS [ 49.578 s]
> [INFO] Lens CLI ........................................... SUCCESS [03:48 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 12.548 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.504 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [02:03 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  3.647 s]
> [INFO] Lens Regression .................................... SUCCESS [ 15.211 s]
> [INFO] Lens UI ............................................ SUCCESS [  6.025 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:04 min
> [INFO] Finished at: 2015-09-25T19:29:26+05:30
> [INFO] Final Memory: 215M/2967M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>