You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2026/05/17 12:38:11 UTC
[PR] Debug log unpacking [maven-dependency-plugin]
elharo opened a new pull request, #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624
We've been logging this when info logs are not enabled and not logging it when they are. Either way, these logs are noisy so set this to to log at debug level.
fixes #1618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Debug log unpacking [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624#issuecomment-4471794693
Simillary here title of PR not describe what we do ....
Will be used in release notes, please look:
https://github.com/apache/maven-dependency-plugin/releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log unpacking at debug level [maven-dependency-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624#issuecomment-4472176968
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Debug log unpacking [maven-dependency-plugin]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624#discussion_r3254641523
##########
src/main/java/org/apache/maven/plugins/dependency/utils/UnpackUtil.java:
##########
@@ -156,32 +156,30 @@ public void unpack(
}
private void logUnpack(Log logger, File file, File location, String includes, String excludes) {
- if (logger.isInfoEnabled()) {
- return;
- }
+ if (logger.isDebugEnabled()) {
+ StringBuilder msg = new StringBuilder();
+ msg.append("Unpacking ");
+ msg.append(file);
+ msg.append(" to ");
+ msg.append(location);
+
+ if (includes != null && excludes != null) {
+ msg.append(" with includes \"");
+ msg.append(includes);
+ msg.append("\" and excludes \"");
+ msg.append(excludes);
+ msg.append("\"");
+ } else if (includes != null) {
+ msg.append(" with includes \"");
+ msg.append(includes);
+ msg.append("\"");
+ } else if (excludes != null) {
+ msg.append(" with excludes \"");
+ msg.append(excludes);
+ msg.append("\"");
+ }
- StringBuilder msg = new StringBuilder();
- msg.append("Unpacking ");
- msg.append(file);
- msg.append(" to ");
- msg.append(location);
-
- if (includes != null && excludes != null) {
- msg.append(" with includes \"");
- msg.append(includes);
- msg.append("\" and excludes \"");
- msg.append(excludes);
- msg.append("\"");
- } else if (includes != null) {
- msg.append(" with includes \"");
- msg.append(includes);
- msg.append("\"");
- } else if (excludes != null) {
- msg.append(" with excludes \"");
- msg.append(excludes);
- msg.append("\"");
+ logger.debug(msg.toString());
}
Review Comment:
`logUnpack()` gates on `logger.isDebugEnabled()` but then logs via `logger.info(...)`. This means the message is still emitted at INFO level (and may not show at all if INFO is disabled), which doesn’t match the PR/issue intent of moving this noisy message to DEBUG. Use `logger.debug(...)` here (and optionally early-return when `!logger.isDebugEnabled()` to avoid building the message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log unpacking at debug level [maven-dependency-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Log unpacking at debug level [maven-dependency-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624#issuecomment-4472319428
@elharo Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Debug log unpacking [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #1624:
URL: https://github.com/apache/maven-dependency-plugin/pull/1624#issuecomment-4471800059
also labels is used to categorize PR in release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org