You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/17 13:24:38 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2392: Fix coordinator check in Monitor
milleruntime opened a new pull request #2392:
URL: https://github.com/apache/accumulo/pull/2392
* Monitor would stop checking for the coordinator once it found it
* This fix will detect if the coordinator moves or is no longer available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2392: Fix coordinator check in Monitor
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2392:
URL: https://github.com/apache/accumulo/pull/2392#issuecomment-998153437
If the Monitor can no longer get the connection to the coordinator it will through an exception here:
https://github.com/apache/accumulo/blob/c19fc7c62bc4458e2530db18125352fd04680731/server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java#L676-L682
This PR is mostly for the page to detect when the Coordinator can't be found or moved. The page itself will throw Datatables pop-up errors with a message that is not very helpful. With this change you can still see those errors before the next interval is reached but after a minute the monitor will detect that its gone and show the "Compaction Coordinator Not Running" message on the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime edited a comment on pull request #2392: Fix coordinator check in Monitor
Posted by GitBox <gi...@apache.org>.
milleruntime edited a comment on pull request #2392:
URL: https://github.com/apache/accumulo/pull/2392#issuecomment-998153437
If the Monitor can no longer get the connection to the coordinator it will throw an exception here:
https://github.com/apache/accumulo/blob/c19fc7c62bc4458e2530db18125352fd04680731/server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java#L676-L682
This PR is mostly for the page to detect when the Coordinator can't be found or moved. The page itself will throw Datatables pop-up errors with a message that is not very helpful. With this change you can still see those errors before the next interval is reached but after a minute the monitor will detect that its gone and show the "Compaction Coordinator Not Running" message on the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2392: Fix coordinator check in Monitor
Posted by GitBox <gi...@apache.org>.
dlmarion commented on pull request #2392:
URL: https://github.com/apache/accumulo/pull/2392#issuecomment-997017620
FWIW, the Compactor uses [this](https://github.com/apache/accumulo/blob/e0853b7715f9712ad05168b727ebc916a7aeb200/server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java#L476) to get the Coordinator connection. This has the downside of calling ZK every time, which I think might be cached, but should pick up the case that the Coordinator is down (throws a Transport Exception) or if it moves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2392: Fix coordinator check in Monitor
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2392:
URL: https://github.com/apache/accumulo/pull/2392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org