You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/11/18 19:19:57 UTC
[GitHub] incubator-brooklyn pull request: Review rest-client's dependencies
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1044
Review rest-client's dependencies
Removes a few that are unused, marks `org.eclipse.jetty:jetty-server` as a test dependency and excludes `brooklyn-utils-rest-swagger` (which transitively means Scala is not pulled in). Downstream clients should be much lighter weight (in the order of 10Mb if they package rest-client's dependencies).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn restclient-deps
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1044.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1044
----
commit f76d032fac63945da63f8ce1888f2e6f0765d301
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-11-18T17:44:51Z
Review rest-client's dependencies
In particular, the dependency on org.eclipse.jetty:jetty-server should
be restricted to the test scope!
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Review rest-client's dependencies
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1044#issuecomment-157943824
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Review rest-client's dependencies
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1044#issuecomment-157808997
I've confirmed the Maven plugin continues to work as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Review rest-client's dependencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Review rest-client's dependencies
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1044#issuecomment-157808828
@robertgmoss Could you double check this against the CF broker please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---