You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Nalley <da...@gnsa.us> on 2013/07/18 17:57:31 UTC
Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12660/
-----------------------------------------------------------
(Updated July 18, 2013, 3:57 p.m.)
Review request for cloudstack and Wido den Hollander.
Repository: cloudstack-git
Description
-------
Replaced multiple grep/awk/head commands by one awk.
Diffs
-----
scripts/vm/network/security_group.py c1c87da
Diff: https://reviews.apache.org/r/12660/diff/
Testing
-------
Tested output. Not able to test using cloudstack function execute() or real ebtables output.
Thanks,
Rene Diepstraten
Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On July 26, 2013, 10:24 p.m., Jenkins Cloudstack.org wrote:
> > Review 12660 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #55 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/
Patch needs to br updated, fails the build
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12660/#review23982
-----------------------------------------------------------
On July 18, 2013, 3:57 p.m., Rene Diepstraten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12660/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 3:57 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Replaced multiple grep/awk/head commands by one awk.
>
>
> Diffs
> -----
>
> scripts/vm/network/security_group.py c1c87da
>
> Diff: https://reviews.apache.org/r/12660/diff/
>
>
> Testing
> -------
>
> Tested output. Not able to test using cloudstack function execute() or real ebtables output.
>
>
> Thanks,
>
> Rene Diepstraten
>
>
Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk
Posted by Amogh Vasekar <am...@citrix.com>.
> On July 26, 2013, 10:24 p.m., Jenkins Cloudstack.org wrote:
> > Review 12660 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #55 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/
>
> Animesh Chaturvedi wrote:
> Patch needs to br updated, fails the build
Reminder -
Hi,
This request has been pending for long. Please take the time to address the comments raised. Thanks!
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12660/#review23982
-----------------------------------------------------------
On July 18, 2013, 3:57 p.m., Rene Diepstraten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12660/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 3:57 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Replaced multiple grep/awk/head commands by one awk.
>
>
> Diffs
> -----
>
> scripts/vm/network/security_group.py c1c87da
>
> Diff: https://reviews.apache.org/r/12660/diff/
>
>
> Testing
> -------
>
> Tested output. Not able to test using cloudstack function execute() or real ebtables output.
>
>
> Thanks,
>
> Rene Diepstraten
>
>
Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12660/#review23982
-----------------------------------------------------------
Review 12660 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #55 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/
- Jenkins Cloudstack.org
On July 18, 2013, 3:57 p.m., Rene Diepstraten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12660/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 3:57 p.m.)
>
>
> Review request for cloudstack and Wido den Hollander.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Replaced multiple grep/awk/head commands by one awk.
>
>
> Diffs
> -----
>
> scripts/vm/network/security_group.py c1c87da
>
> Diff: https://reviews.apache.org/r/12660/diff/
>
>
> Testing
> -------
>
> Tested output. Not able to test using cloudstack function execute() or real ebtables output.
>
>
> Thanks,
>
> Rene Diepstraten
>
>