You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Alan Woodward (JIRA)" <ji...@apache.org> on 2015/02/19 10:54:14 UTC
[jira] [Commented] (LUCENE-6256) PostingsEnum impls should respect
documented behavior when no positions exist
[ https://issues.apache.org/jira/browse/LUCENE-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327177#comment-14327177 ]
Alan Woodward commented on LUCENE-6256:
---------------------------------------
+1
The javadoc is a straight error on my part, a remnant from a previous attempt at reworking the API. The assertions were in there to check that the codecs were returning the correct PostingsEnum implementation when postings() was called, but they're pretty superfluous.
> PostingsEnum impls should respect documented behavior when no positions exist
> -----------------------------------------------------------------------------
>
> Key: LUCENE-6256
> URL: https://issues.apache.org/jira/browse/LUCENE-6256
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ryan Ernst
> Attachments: LUCENE-6256.patch
>
>
> {{PostingsEnum.nextPositions}} says that if no positions exist, NO_MORE_POSITIONS will be returned on the first call (actually it refers to DocsEnum.NO_MORE_DOCS, which should be changed since DocsEnum doesn't exist on trunk). At least one impl (BlockDocsEnum) does {{assert false}} inside {{nextPosition()}}. This means if you have assertions turned on (e.g. in a test) you get an assertion here, when the behavior should return NO_MORE_POSITIONS. I'm still going through all the implementations, but I also see {{MultiTermHighlighting}} which returns {{Integer.MAX_VALUE}}. I think we should clean up all these implementations which have no positions (including maybe the fake scorers that are copied around in a lot of places?) to return NO_MORE_POSITIONS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org