You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/10 18:15:00 UTC

[jira] [Commented] (ASTERIXDB-2667) Share code between string functions

    [ https://issues.apache.org/jira/browse/ASTERIXDB-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992787#comment-16992787 ] 

ASF subversion and git services commented on ASTERIXDB-2667:
------------------------------------------------------------

Commit b0919afbf42e7a7cf942d1b0f6d6d29b178b34fd in asterixdb's branch refs/heads/master from Hussain Towaileb
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=b0919af ]

[ASTERIXDB-2667][FUN] Share code base between string functions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- String functions concat, string_concat and string_join
  now share the same code instead of each having a different
  evaluator class.
- Added test cases for string_join function.
- Added support to deep missing/null checking in list
  items. Now it's possible to give a deeper (list items)
  missing value a higher priority over null arguments
  outside a list between parameters.
  Example:
  somefun([1, missing], null);
  It's possible to deeply check the list items first,
  and hence return a missing, or only do first level check
  and output would be null.

Change-Id: I41b644c6841b222d1c6c529b2f9189f42178e28c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4023
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hu...@gmail.com>
Reviewed-by: Ali Alsuliman <al...@gmail.com>


> Share code between string functions
> -----------------------------------
>
>                 Key: ASTERIXDB-2667
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2667
>             Project: Apache AsterixDB
>          Issue Type: Improvement
>          Components: FUN - Functions
>    Affects Versions: 0.9.4.1
>            Reporter: Hussain Towaileb
>            Assignee: Hussain Towaileb
>            Priority: Major
>             Fix For: 0.9.5
>
>
> The string functions concat, string_concat and string_join have a very similar behavior, they can be sharing the same code base instead of having a different evaluator for each function



--
This message was sent by Atlassian Jira
(v8.3.4#803005)