[GitHub] [gobblin] Will-Lo commented on a change in pull request #3353: [GOBBLIN-1507] Prevent orchestrator removals when unscheduling flows

[GitBox <gi...@apache.org>]

Will-Lo commented on a change in pull request #3353:
URL: https://github.com/apache/gobblin/pull/3353#discussion_r684470352



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -347,6 +343,30 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
     return new AddSpecResponse<>(response);
   }
 
+  /**
+   * Remove a flowSpec from schedule due to another leader being elected
+   * Unlike onDeleteSpec, we want to avoid deleting the flowSpec on the executor
+   * and we still want to unschedule if we cannot connect to zookeeper as the current node cannot be the master
+   * @param specURI
+   * @param specVersion
+   */
+  private void unscheduleSpec(URI specURI, String specVersion) {

Review comment:
       onDeleteSpec also checks for connection to zookeeper though, and I think that's a bad check if the host is demoted. If a host that used to be master gets demoted, it's likely struggling with connectivity so unscheduleSpec handles that.
   
   @arjun4084346 can do that too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org