You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/10/14 20:06:34 UTC
Review Request 26701: Updated master to update task unacknowledged
state properly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Bugs: MESOS-1799 and MESOS-1817
https://issues.apache.org/jira/browse/MESOS-1799
https://issues.apache.org/jira/browse/MESOS-1817
Repository: mesos-git
Description
-------
Master now maintains the latest and unacknowledged states of the task.
Diffs
-----
src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d
src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99
src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
Diff: https://reviews.apache.org/r/26701/diff/
Testing
-------
make check
Ran the new test 1000 times.
Thanks,
Vinod Kone
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 15, 2014, 7:23 a.m., Adam B wrote:
> > src/master/master.cpp, line 2826
> > <https://reviews.apache.org/r/26701/diff/1/?file=720977#file720977line2826>
> >
> > When would the uuids ever be different? If the scheduler re-acked a previous terminal update when the master expected to be on a second terminal update/ack?
it could be different because status update manager retries updates. for example, SUM sent 2 TASK_RUNNING updates (one of them a retry). before the ACK for the 2nd TASK_RUNNING reaches master, if it received a TASK_FINISHED update, we would accidentally remove the task on the reception of the 2nd TASK_RUNNING ACK.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/#review56656
-----------------------------------------------------------
On Oct. 14, 2014, 6:06 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26701/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 6:06 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1799 and MESOS-1817
> https://issues.apache.org/jira/browse/MESOS-1799
> https://issues.apache.org/jira/browse/MESOS-1817
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master now maintains the latest and unacknowledged states of the task.
>
>
> Diffs
> -----
>
> src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
> src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d
> src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99
> src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
>
> Diff: https://reviews.apache.org/r/26701/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the new test 1000 times.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/#review56656
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97065>
s/unacknowleded/unacknowledged/
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97066>
When would the uuids ever be different? If the scheduler re-acked a previous terminal update when the master expected to be on a second terminal update/ack?
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97063>
s/do prevent/do, prevent/
src/messages/messages.proto
<https://reviews.apache.org/r/26701/#comment97057>
s/lateset/latest/
- Adam B
On Oct. 14, 2014, 11:06 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26701/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 11:06 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1799 and MESOS-1817
> https://issues.apache.org/jira/browse/MESOS-1799
> https://issues.apache.org/jira/browse/MESOS-1817
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master now maintains the latest and unacknowledged states of the task.
>
>
> Diffs
> -----
>
> src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
> src/master/master.cpp cb46cec0674b3aa031450c5b4f48f4f8bb92767d
> src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99
> src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
>
> Diff: https://reviews.apache.org/r/26701/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the new test 1000 times.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 2811-2816
> > <https://reviews.apache.org/r/26701/diff/3/?file=723865#file723865line2811>
> >
> > Isn't there a bit more to this comment?
> >
> > If this is a 0.21.0 master and there are 0.20.0 slaves, this all makes sense (the 0.20.0 slaves will not send this field when re-registering so we won't have it here as you said).
> >
> > However, if this is a 0.21.0 master and there are 0.21.0 slaves, then the state would have been set when the slave re-registered with the `Task`, right..?
> >
> > We never unset the unacknowledged state when an acknowledgement occurs on the slave either. "unacknowledged" now seems a bit confusing.
> >
> > Let's chat on Monday so I can understand this a bit better :)
>
> Vinod Kone wrote:
> The unacknowledged state of the task will be set by the 0.21.0 *master* when it receives an update from either 0.20.0 or 0.21.0 slave. That is why this comment doesn't talk about the slave versions.
>
> Ben Mahler wrote:
> Hm.. per our chat, can you update this to be an ERROR log, since this should only be possible when 0.20.0 slaves are present?
done.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/#review57285
-----------------------------------------------------------
On Oct. 21, 2014, 10:24 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26701/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 10:24 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1799 and MESOS-1817
> https://issues.apache.org/jira/browse/MESOS-1799
> https://issues.apache.org/jira/browse/MESOS-1817
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master now maintains the latest and unacknowledged states of the task.
>
>
> Diffs
> -----
>
> src/master/master.hpp 18898e9e1897b9d8cecd10d0ef7f25540cc9916d
> src/master/master.cpp be910d9f02405e25e5ad6ae3bf13d770a0c2b417
> src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
>
> Diff: https://reviews.apache.org/r/26701/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the new test 1000 times.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > Code looks good, thanks! Mostly left comments around better comments, and some minor code movement.
> >
> > Curious if we can pick a better name for `unacknowledged_state` in `Task`:
> >
> > `status_update_state`
> > `status_update_uuid`
> >
> > `current_status_update_state`
> > `current_status_update_uuid`
> >
> > `latest_status_update_state`
> > `latest_status_update_uuid`
picked status_update_state.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 2811-2816
> > <https://reviews.apache.org/r/26701/diff/3/?file=723865#file723865line2811>
> >
> > Isn't there a bit more to this comment?
> >
> > If this is a 0.21.0 master and there are 0.20.0 slaves, this all makes sense (the 0.20.0 slaves will not send this field when re-registering so we won't have it here as you said).
> >
> > However, if this is a 0.21.0 master and there are 0.21.0 slaves, then the state would have been set when the slave re-registered with the `Task`, right..?
> >
> > We never unset the unacknowledged state when an acknowledgement occurs on the slave either. "unacknowledged" now seems a bit confusing.
> >
> > Let's chat on Monday so I can understand this a bit better :)
The unacknowledged state of the task will be set by the 0.21.0 *master* when it receives an update from either 0.20.0 or 0.21.0 slave. That is why this comment doesn't talk about the slave versions.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 2825-2827
> > <https://reviews.apache.org/r/26701/diff/3/?file=723865#file723865line2825>
> >
> > Could have the following above:
> >
> > // Must be set or unset together.
> > CHECK(task->has_unacknoweldged_uuid() == task->has_unacknowledged_state());
done
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 4549-4555
> > <https://reviews.apache.org/r/26701/diff/3/?file=723865#file723865line4549>
> >
> > Looks like this can be wrapped at the LOG(INFO) << line while still being under 80 characters:
> >
> > len(' LOG(INFO) << "Updating the latest state of task " << task->task_id()')
> > len(' << " of framework " << task->framework_id()')
> > len(' << " to " << task->state()')
> > len(' << (task->state() != status.state()')
> > len(' ? " (unacknowledged state: " + stringify(status.state()) + ")"')
> > len(' : "");')
> >
> > Longest line is 78 characters..?
done.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/tests/master_tests.cpp, lines 2363-2366
> > <https://reviews.apache.org/r/26701/diff/3/?file=723866#file723866line2363>
> >
> > Quite the long sentence ;)
rephrased.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/tests/master_tests.cpp, line 2367
> > <https://reviews.apache.org/r/26701/diff/3/?file=723866#file723866line2367>
> >
> > We should probably encode the release of resources in the name?
> >
> > ReleaseResourcesForTerminalTaskWithPendingUpdates
ok.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/#review57285
-----------------------------------------------------------
On Oct. 17, 2014, 12:31 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26701/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 12:31 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1799 and MESOS-1817
> https://issues.apache.org/jira/browse/MESOS-1799
> https://issues.apache.org/jira/browse/MESOS-1817
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master now maintains the latest and unacknowledged states of the task.
>
>
> Diffs
> -----
>
> src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
> src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
> src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
>
> Diff: https://reviews.apache.org/r/26701/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the new test 1000 times.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 18, 2014, 11:15 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 2811-2816
> > <https://reviews.apache.org/r/26701/diff/3/?file=723865#file723865line2811>
> >
> > Isn't there a bit more to this comment?
> >
> > If this is a 0.21.0 master and there are 0.20.0 slaves, this all makes sense (the 0.20.0 slaves will not send this field when re-registering so we won't have it here as you said).
> >
> > However, if this is a 0.21.0 master and there are 0.21.0 slaves, then the state would have been set when the slave re-registered with the `Task`, right..?
> >
> > We never unset the unacknowledged state when an acknowledgement occurs on the slave either. "unacknowledged" now seems a bit confusing.
> >
> > Let's chat on Monday so I can understand this a bit better :)
>
> Vinod Kone wrote:
> The unacknowledged state of the task will be set by the 0.21.0 *master* when it receives an update from either 0.20.0 or 0.21.0 slave. That is why this comment doesn't talk about the slave versions.
Hm.. per our chat, can you update this to be an ERROR log, since this should only be possible when 0.20.0 slaves are present?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/#review57285
-----------------------------------------------------------
On Oct. 20, 2014, 11:57 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26701/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 11:57 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1799 and MESOS-1817
> https://issues.apache.org/jira/browse/MESOS-1799
> https://issues.apache.org/jira/browse/MESOS-1817
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master now maintains the latest and unacknowledged states of the task.
>
>
> Diffs
> -----
>
> src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
> src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
> src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
>
> Diff: https://reviews.apache.org/r/26701/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the new test 1000 times.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/#review57285
-----------------------------------------------------------
Ship it!
Code looks good, thanks! Mostly left comments around better comments, and some minor code movement.
Curious if we can pick a better name for `unacknowledged_state` in `Task`:
`status_update_state`
`status_update_uuid`
`current_status_update_state`
`current_status_update_uuid`
`latest_status_update_state`
`latest_status_update_uuid`
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97845>
Isn't there a bit more to this comment?
If this is a 0.21.0 master and there are 0.20.0 slaves, this all makes sense (the 0.20.0 slaves will not send this field when re-registering so we won't have it here as you said).
However, if this is a 0.21.0 master and there are 0.21.0 slaves, then the state would have been set when the slave re-registered with the `Task`, right..?
We never unset the unacknowledged state when an acknowledgement occurs on the slave either. "unacknowledged" now seems a bit confusing.
Let's chat on Monday so I can understand this a bit better :)
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97846>
Hopefully in clarifying my comment above we can be a little more specific in this warning message.
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97847>
Could have the following above:
// Must be set or unset together.
CHECK(task->has_unacknoweldged_uuid() == task->has_unacknowledged_state());
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97848>
Maybe warrants a comment:
// We remove the task once a terminal update has
// been acknowledged by the framework.
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97850>
Why not move this down to where it's used?
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97849>
I'm a bit worried about this TODO because it's too inquisitive, someone coming along here doesn't have any context and might think we can remove this.
It should not be possible, but to protect against bugs here a CHECK is probably too severe, which means we'll continue to log an error and guard it, in which case we should just update the comment as a NOTE about this.
Are you thinking of other alternatives?
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97851>
Can you set the state in the similar if / else above, any reason to do the same check twice?
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97852>
Seems nice to move this up as well (when you move `set_state` up).
src/master/master.cpp
<https://reviews.apache.org/r/26701/#comment97853>
Looks like this can be wrapped at the LOG(INFO) << line while still being under 80 characters:
len(' LOG(INFO) << "Updating the latest state of task " << task->task_id()')
len(' << " of framework " << task->framework_id()')
len(' << " to " << task->state()')
len(' << (task->state() != status.state()')
len(' ? " (unacknowledged state: " + stringify(status.state()) + ")"')
len(' : "");')
Longest line is 78 characters..?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/26701/#comment97854>
Quite the long sentence ;)
src/tests/master_tests.cpp
<https://reviews.apache.org/r/26701/#comment97855>
We should probably encode the release of resources in the name?
ReleaseResourcesForTerminalTaskWithPendingUpdates
- Ben Mahler
On Oct. 17, 2014, 12:31 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26701/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 12:31 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1799 and MESOS-1817
> https://issues.apache.org/jira/browse/MESOS-1799
> https://issues.apache.org/jira/browse/MESOS-1817
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master now maintains the latest and unacknowledged states of the task.
>
>
> Diffs
> -----
>
> src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
> src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
> src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
>
> Diff: https://reviews.apache.org/r/26701/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran the new test 1000 times.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/
-----------------------------------------------------------
(Updated Oct. 21, 2014, 10:24 p.m.)
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Changes
-------
benm's. NNFR.
Bugs: MESOS-1799 and MESOS-1817
https://issues.apache.org/jira/browse/MESOS-1799
https://issues.apache.org/jira/browse/MESOS-1817
Repository: mesos-git
Description
-------
Master now maintains the latest and unacknowledged states of the task.
Diffs (updated)
-----
src/master/master.hpp 18898e9e1897b9d8cecd10d0ef7f25540cc9916d
src/master/master.cpp be910d9f02405e25e5ad6ae3bf13d770a0c2b417
src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
Diff: https://reviews.apache.org/r/26701/diff/
Testing
-------
make check
Ran the new test 1000 times.
Thanks,
Vinod Kone
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 11:57 p.m.)
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Changes
-------
addressed comments.
Bugs: MESOS-1799 and MESOS-1817
https://issues.apache.org/jira/browse/MESOS-1799
https://issues.apache.org/jira/browse/MESOS-1817
Repository: mesos-git
Description
-------
Master now maintains the latest and unacknowledged states of the task.
Diffs (updated)
-----
src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
Diff: https://reviews.apache.org/r/26701/diff/
Testing
-------
make check
Ran the new test 1000 times.
Thanks,
Vinod Kone
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 12:31 a.m.)
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Changes
-------
No functional changes. Rebased.
Bugs: MESOS-1799 and MESOS-1817
https://issues.apache.org/jira/browse/MESOS-1799
https://issues.apache.org/jira/browse/MESOS-1817
Repository: mesos-git
Description
-------
Master now maintains the latest and unacknowledged states of the task.
Diffs (updated)
-----
src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
Diff: https://reviews.apache.org/r/26701/diff/
Testing
-------
make check
Ran the new test 1000 times.
Thanks,
Vinod Kone
Re: Review Request 26701: Updated master to update task
unacknowledged state properly.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26701/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 9:32 p.m.)
Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.
Changes
-------
Addressed comments.
Bugs: MESOS-1799 and MESOS-1817
https://issues.apache.org/jira/browse/MESOS-1799
https://issues.apache.org/jira/browse/MESOS-1817
Repository: mesos-git
Description
-------
Master now maintains the latest and unacknowledged states of the task.
Diffs (updated)
-----
src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205
src/master/master.cpp 1b1ce0de3065ced45890777d42c69ef1091f5699
src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99
src/tests/master_tests.cpp d9dc40c6f5aaa66e1f7a0e1b7e4d9cdc586ca0fd
Diff: https://reviews.apache.org/r/26701/diff/
Testing
-------
make check
Ran the new test 1000 times.
Thanks,
Vinod Kone