You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2015/10/05 09:55:30 UTC
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/912
Fix bugs on last step on Wizard zone and Adv Search box
Javascript error: Uncaught ReferenceError: _ is not defined
=> Missing 'l' (to call the _l() function)
Bug introduce by me (#712)
For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)
=
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack BugZoneWizardAndAdvSearchPopup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #912
----
commit 351ffe1fb5d266bd992cb88e9ba1d23290d8fa4a
Author: Milamber <mi...@apache.org>
Date: 2015-10-05T07:01:20Z
Fix bugs on last step on Wizard zone and Adv Search box
Javascript error: Uncaught ReferenceError: _ is not defined
=> Missing 'l' (to call the _l() function)
Bug introduce by me (#712)
For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)
=
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145455703
@remibergsma
Probably this is a 'minor' blocker bug for the 4.6 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145668698
@runseb Good catch!
Thanks @nitin-maharana to fix part of this bugs.
@remibergsma my PR add a bug on Adv search label.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145655920
@milamberspace Thanks, this we should include indeed. Will try to test in the coming days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145853416
I tried to run the wizard with this patch applied but the wizard doesn't show 'finished' nor does it finish after pressing 'next' for a final time. I shows a blank screen and then loops back to the beginning of the wizard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145661229
@milamberspace @remibergsma there is a duplicate at https://github.com/apache/cloudstack/pull/906
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145985072
@DaanHoogland you need to double-check that the old zoneWizard.js file is changed on you browser (clean cache) and on the tomcat installation (if not a new installation) in work/temp dir. I have a lot of problem to test that because even I clean my browser cache, the tomcat service continue to serve the old zoneWizard.js without the L in the _l() function. Finally I made a full clean installation of CS to validate my fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-146095698
Closed. New PR #915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/912
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---