You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by mi...@apache.org on 2016/05/06 14:43:51 UTC

[41/50] logging-log4j2 git commit: LOG4J2-1179 refactor IPerfTestRunner implementation to avoid Logger lookup in #log() method

LOG4J2-1179 refactor IPerfTestRunner implementation to avoid Logger lookup in #log() method


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/69a1ac2f
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/69a1ac2f
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/69a1ac2f

Branch: refs/heads/LOG4J-1181
Commit: 69a1ac2f565dbd39c2f348691c5ae97b8659301a
Parents: 6e72fe6
Author: rpopma <rp...@apache.org>
Authored: Thu May 5 10:05:09 2016 +0900
Committer: rpopma <rp...@apache.org>
Committed: Thu May 5 10:05:09 2016 +0900

----------------------------------------------------------------------
 .../apache/logging/log4j/core/async/perftest/RunLog4j1.java | 9 +++++----
 .../apache/logging/log4j/core/async/perftest/RunLog4j2.java | 8 ++++----
 .../logging/log4j/core/async/perftest/RunLogback.java       | 8 ++++----
 3 files changed, 13 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/69a1ac2f/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j1.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j1.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j1.java
index 3903528..6db549e 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j1.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j1.java
@@ -23,10 +23,12 @@ import com.lmax.disruptor.collections.Histogram;
 
 public class RunLog4j1 implements IPerfTestRunner {
 
+    final Logger LOGGER = LogManager.getLogger(getClass());
+
     @Override
     public void runThroughputTest(final int lines, final Histogram histogram) {
         final long s1 = System.nanoTime();
-        final Logger logger = LogManager.getLogger(getClass());
+        final Logger logger = LOGGER;
         for (int j = 0; j < lines; j++) {
             logger.info(THROUGHPUT_MSG);
         }
@@ -38,7 +40,7 @@ public class RunLog4j1 implements IPerfTestRunner {
     @Override
     public void runLatencyTest(final int samples, final Histogram histogram,
             final long nanoTimeCost, final int threadCount) {
-        final Logger logger = LogManager.getLogger(getClass());
+        final Logger logger = LOGGER;
         for (int i = 0; i < samples; i++) {
             final long s1 = System.nanoTime();
             logger.info(LATENCY_MSG);
@@ -63,7 +65,6 @@ public class RunLog4j1 implements IPerfTestRunner {
 
     @Override
     public void log(final String finalMessage) {
-        final Logger logger = LogManager.getLogger(getClass());
-        logger.info(finalMessage);
+        LOGGER.info(finalMessage);
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/69a1ac2f/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j2.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j2.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j2.java
index bcfaa92..df2a15d 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j2.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLog4j2.java
@@ -22,11 +22,12 @@ import org.apache.logging.log4j.core.CoreLoggerContexts;
 import com.lmax.disruptor.collections.Histogram;
 
 public class RunLog4j2 implements IPerfTestRunner {
+    final Logger LOGGER = LogManager.getLogger(getClass());
 
     @Override
     public void runThroughputTest(final int lines, final Histogram histogram) {
         final long s1 = System.nanoTime();
-        final Logger logger = LogManager.getLogger(getClass());
+        final Logger logger = LOGGER;
         for (int j = 0; j < lines; j++) {
             logger.info(THROUGHPUT_MSG);
         }
@@ -39,7 +40,7 @@ public class RunLog4j2 implements IPerfTestRunner {
     @Override
     public void runLatencyTest(final int samples, final Histogram histogram,
             final long nanoTimeCost, final int threadCount) {
-        final Logger logger = LogManager.getLogger(getClass());
+        final Logger logger = LOGGER;
         for (int i = 0; i < samples; i++) {
             final long s1 = System.nanoTime();
             logger.info(LATENCY_MSG);
@@ -66,7 +67,6 @@ public class RunLog4j2 implements IPerfTestRunner {
 
     @Override
     public void log(final String finalMessage) {
-        final Logger logger = LogManager.getLogger(getClass());
-        logger.info(finalMessage);
+        LOGGER.info(finalMessage);
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/69a1ac2f/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLogback.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLogback.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLogback.java
index c6f0c29..aaf22c6 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLogback.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/RunLogback.java
@@ -24,11 +24,12 @@ import ch.qos.logback.core.spi.LifeCycle;
 import com.lmax.disruptor.collections.Histogram;
 
 public class RunLogback implements IPerfTestRunner {
+    final Logger LOGGER = (Logger) LoggerFactory.getLogger(getClass());
 
     @Override
     public void runThroughputTest(final int lines, final Histogram histogram) {
         final long s1 = System.nanoTime();
-        final Logger logger = (Logger) LoggerFactory.getLogger(getClass());
+        final Logger logger = LOGGER;
         for (int j = 0; j < lines; j++) {
             logger.info(THROUGHPUT_MSG);
         }
@@ -40,7 +41,7 @@ public class RunLogback implements IPerfTestRunner {
     @Override
     public void runLatencyTest(final int samples, final Histogram histogram,
             final long nanoTimeCost, final int threadCount) {
-        final Logger logger = (Logger) LoggerFactory.getLogger(getClass());
+        final Logger logger = LOGGER;
         for (int i = 0; i < samples; i++) {
             final long s1 = System.nanoTime();
             logger.info(LATENCY_MSG);
@@ -65,7 +66,6 @@ public class RunLogback implements IPerfTestRunner {
 
     @Override
     public void log(final String msg) {
-        final Logger logger = (Logger) LoggerFactory.getLogger(getClass());
-        logger.info(msg);
+        LOGGER.info(msg);
     }
 }