You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Michael-J-Ward (via GitHub)" <gi...@apache.org> on 2024/07/24 23:00:38 UTC

[I] functions_aggregate::expr_fn::approx_distinct should expose the function, not the module [datafusion]

Michael-J-Ward opened a new issue, #11643:
URL: https://github.com/apache/datafusion/issues/11643

   ### Describe the bug
   
   Currently, `functions_aggregate::expr_fn::approx_distinct` points to the module, not the fluent API function.
   
   https://github.com/apache/datafusion/blob/20b298e9d82e483e28087e595c409a8cc04872f3/datafusion/functions-aggregate/src/lib.rs#L92-L96
   
   
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   `functions_aggregate::expr_fn::approx_distinct` should reference the fluent API for creating a UDAf.
   
   ### Additional context
   
   I'll have a PR shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] functions_aggregate::expr_fn::approx_distinct should expose the function, not the module [datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 closed issue #11643: functions_aggregate::expr_fn::approx_distinct should expose the function, not the module
URL: https://github.com/apache/datafusion/issues/11643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] functions_aggregate::expr_fn::approx_distinct should expose the function, not the module [datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 closed issue #11643: functions_aggregate::expr_fn::approx_distinct should expose the function, not the module
URL: https://github.com/apache/datafusion/issues/11643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org