You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by GitBox <gi...@apache.org> on 2017/11/26 20:37:25 UTC

[GitHub] mdindoffer opened a new pull request #295: Drop usage of FileInput/OutputStreams - modules a* -> c*

mdindoffer opened a new pull request #295: Drop usage of FileInput/OutputStreams - modules a* -> c*
URL: https://github.com/apache/incubator-netbeans/pull/295
 
 
   This change drops the usage of FileInputStream and FileOutputStream
   in cluster modules "a*" through "c*".
   The FIS/FOS are putting unnecesary pressure on the GC because of their finalize() method.
   I've measured small, but fairly consistent improvements in GC pauses during the startup of the IDE with couple of projects opened:
   Before: http://gceasy.io/my-gc-report.jsp?p=c2hhcmVkLzIwMTcvMTEvMjYvLS1nYXJiYWdlLWNvbGxlY3Rpb24tYmVmb3JlLXN0YXJ0dXAubG9nLS0yMC0xMS01OQ==
   After: http://gceasy.io/my-gc-report.jsp?p=c2hhcmVkLzIwMTcvMTEvMjYvLS1nYXJiYWdlLWNvbGxlY3Rpb24tYWZ0ZXIxY29tbWl0LXN0YXJ0dXAubG9nLS0yMC0xMy01Mw==
   In every module that required it (for the "Files" class workaround), theres a bump in javac source to version 7. Where appropriate I took the liberty of using try with resources blocks.
   I may have also fixed a resource leak somewhere in there.
   Further references: see JDK-8080225, HDFS-8526, JENKINS-42934

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services