You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Everett Toews <no...@github.com> on 2014/04/25 18:03:52 UTC
[jclouds-site] Always display the latest release on the home page
(#89)
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-site release-news
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/89
-- Commit Summary --
* Always display the latest release on the home page
-- File Changes --
M _config.yml (1)
M _includes/news.md (9)
M _layouts/home.html (5)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/89.patch
https://github.com/jclouds/jclouds-site/pull/89.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Andrew Phillips <no...@github.com>.
> <div id="quicknews" class="alert alert-info">
> -{% for page in site.pages %}
> - {% if page.quicknew %}
> - {% assign newspresent = true %}
> +{% for page in site.pages %}{% if page.quicknew %}{% assign newspresent = true %}
Just out of curiosity...is this needed, or just a style cleanup?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/files#r12026572
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
> @@ -36,6 +36,11 @@
> </div>
> </div>
>
> + <div id="releasenews" class="alert alert-info">
I think it looks okay. I specifically do want separate boxes as the latest version one will always be there.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/files#r12009576
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Andrew Phillips <no...@github.com>.
How about trying this at the top - perhaps a little thinner (or maybe with different shading)?
That also distinguishes it clearly from the Quick News items...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41482487
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -36,6 +36,11 @@
> </div>
> </div>
>
> + <div id="releasenews" class="alert alert-info">
> + <p>The latest version is {{ site.latest_version }} released on {{ site.latest_version_date }}! Read the <a href="/releasenotes/{{ site.latest_version }}/">release notes</a>.</p>
Make the "latest version" a link to the install page? When looking at the staging site, I just naturally tried to click it, so perhaps the link could help.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/files#r12005388
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by jclouds-commentator <no...@github.com>.
Go to http://99ce7be53d1f99a18c89-e4759526888c747a7da3df296b7610f6.r70.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41410055
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
Merged and deployed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41637028
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
Closed #89.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
No thanks. The very first thing on the root page of a web site (especially for something like a Java toolkit) should be a clear explanation of what the thing is about. Moving the latest version to the very top would violate that principle.
Look at it from the perspective of someone who is coming to jclouds.apache.org for the very first time. They're reading about the latest version before they even know what jclouds is.
The appropriate place is below.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41577402
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
> <div id="quicknews" class="alert alert-info">
> -{% for page in site.pages %}
> - {% if page.quicknew %}
> - {% assign newspresent = true %}
> +{% for page in site.pages %}{% if page.quicknew %}{% assign newspresent = true %}
With the way liquid works, having them on the same line generates a ton of newlines even when there is no quick news.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/files#r12053144
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #284](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/284/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41636308
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #279](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/279/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41425766
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Ignasi Barrera <no...@github.com>.
Thx @everett-toews ! Looks great to have the latest release in the main page!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41415813
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -36,6 +36,11 @@
> </div>
> </div>
>
> + <div id="releasenews" class="alert alert-info">
How will this look like if there are quick news? If they show as two separate boxes, will that be good-looking?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/files#r12005448
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by jclouds-commentator <no...@github.com>.
Go to http://96b9bd1ae5b7f07e2654-d8f21cfe0b7c854843639ebcfc3264ff.r99.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41636414
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
I dunno. I'm okay with it the way it is. Adding the version number to the Install button everywhere seems redundant.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41714721
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Everett Toews <no...@github.com>.
> @@ -36,6 +36,11 @@
> </div>
> </div>
>
> + <div id="releasenews" class="alert alert-info">
> + <p>The latest version is {{ site.latest_version }} released on {{ site.latest_version_date }}! Read the <a href="/releasenotes/{{ site.latest_version }}/">release notes</a>.</p>
Sure.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/files#r12009803
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by jclouds-commentator <no...@github.com>.
Go to http://f927b4fe7351a4a00f74-36e5f9506a089c98cbda40fd94170c0d.r53.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41425945
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Andrew Phillips <no...@github.com>.
> They're reading about the latest version before they even know what jclouds is.
Fair point. I'd just respond that, in the current location (and that's also fine for me, by the way), it looks like a "news item" rather than a static piece of always available information. Cf. e.g. Gradle, which actually has _both_ the "static" and "latest news" versions:
How about integrating it somewhere in the "The Java multi-cloud toolkit" box, e.g.
?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41681064
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Ignasi Barrera <no...@github.com>.
Looks nice! Thx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41646430
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by Andrew Phillips <no...@github.com>.
> Adding the version number to the Install button everywhere seems redundant.
An alternative to that:
But also OK to leave as-is - just throwing this out there.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41725210
Re: [jclouds-site] Always display the latest release on the home page
(#89)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #277](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/277/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41409708