You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2010/04/02 20:03:52 UTC

Re: simplify mod_perl.c a bit

+1

On 03/31/10 15:07, Torsten Förtsch wrote:
> Hi,
>
> the patch below simplifies mod_perl.c a bit.
>
> Instead of
>
> modperl_response_handler_run(r, finish) {
>    do something
>    if( finish ) {
>      modperl_response_finish()
>    }
> }
>
> and calling that function in one place as
>
> modperl_response_handler_run(r, TRUE)
>
> and in the second place as
>
> modperl_response_handler_run(r, TRUE)
> do something
> modperl_response_finish()
>
> it now looks like
>
> modperl_response_handler_run(r) {
>    do something
> }
>
> 1st usage:
> modperl_response_handler_run(r)
> modperl_response_finish()
>
> 2nd usage:
> modperl_response_handler_run(r)
> do something
> modperl_response_finish()
>
> Torsten Förtsch
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org


-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: simplify mod_perl.c a bit

Posted by Fred Moyer <fr...@redhotpenguin.com>.
+1

On Fri, Apr 2, 2010 at 11:22 AM, Randy Kobes <ra...@gmail.com> wrote:
> +1.
>
> --
> best regards,
> Randy
>
> On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote:
>
>> +1
>>
>> On 03/31/10 15:07, Torsten Förtsch wrote:
>>> Hi,
>>>
>>> the patch below simplifies mod_perl.c a bit.
>>>
>>> Instead of
>>>
>>> modperl_response_handler_run(r, finish) {
>>>   do something
>>>   if( finish ) {
>>>     modperl_response_finish()
>>>   }
>>> }
>>>
>>> and calling that function in one place as
>>>
>>> modperl_response_handler_run(r, TRUE)
>>>
>>> and in the second place as
>>>
>>> modperl_response_handler_run(r, TRUE)
>>> do something
>>> modperl_response_finish()
>>>
>>> it now looks like
>>>
>>> modperl_response_handler_run(r) {
>>>   do something
>>> }
>>>
>>> 1st usage:
>>> modperl_response_handler_run(r)
>>> modperl_response_finish()
>>>
>>> 2nd usage:
>>> modperl_response_handler_run(r)
>>> do something
>>> modperl_response_finish()
>>>
>>> Torsten Förtsch
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: simplify mod_perl.c a bit

Posted by Randy Kobes <ra...@gmail.com>.
+1.

-- 
best regards,
Randy

On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote:

> +1
> 
> On 03/31/10 15:07, Torsten Förtsch wrote:
>> Hi,
>> 
>> the patch below simplifies mod_perl.c a bit.
>> 
>> Instead of
>> 
>> modperl_response_handler_run(r, finish) {
>>   do something
>>   if( finish ) {
>>     modperl_response_finish()
>>   }
>> }
>> 
>> and calling that function in one place as
>> 
>> modperl_response_handler_run(r, TRUE)
>> 
>> and in the second place as
>> 
>> modperl_response_handler_run(r, TRUE)
>> do something
>> modperl_response_finish()
>> 
>> it now looks like
>> 
>> modperl_response_handler_run(r) {
>>   do something
>> }
>> 
>> 1st usage:
>> modperl_response_handler_run(r)
>> modperl_response_finish()
>> 
>> 2nd usage:
>> modperl_response_handler_run(r)
>> do something
>> modperl_response_finish()
>> 
>> Torsten Förtsch


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org