You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/28 22:59:18 UTC
[GitHub] codecov-io commented on issue #4689: Move has access to superset security manager
codecov-io commented on issue #4689: Move has access to superset security manager
URL: https://github.com/apache/incubator-superset/pull/4689#issuecomment-376723053
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=h1) Report
> Merging [#4689](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7e1b6b7363e1c5dcff92d7e74716192bc0ceaad8?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `92.68%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4689 +/- ##
==========================================
- Coverage 71.56% 71.56% -0.01%
==========================================
Files 191 191
Lines 14958 14957 -1
Branches 1100 1100
==========================================
- Hits 10705 10704 -1
Misses 4250 4250
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4689/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.94% <100%> (-0.18%)` | :arrow_down: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4689/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `71.28% <100%> (-0.29%)` | :arrow_down: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4689/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `67.8% <100%> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4689/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.17% <90%> (ø)` | :arrow_up: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/4689/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `75.72% <94.11%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=footer). Last update [7e1b6b7...48a95c4](https://codecov.io/gh/apache/incubator-superset/pull/4689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services