You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/29 18:12:15 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #13741: ARROW-17247: [C++][Docs] Include visibilty to ExecPlan APIs in Acero Docs

westonpace commented on code in PR #13741:
URL: https://github.com/apache/arrow/pull/13741#discussion_r933510986


##########
cpp/src/arrow/compute/exec.h:
##########
@@ -174,6 +174,10 @@ class ARROW_EXPORT SelectionVector {
 /// TODO: Datum uses arrow/util/variant.h which may be a bit heavier-weight
 /// than is desirable for this class. Microbenchmarks would help determine for
 /// sure. See ARROW-8928.
+
+/// \addtogroup execnode-components

Review Comment:
   This looks like a new group.  You need to add a defgroup [here](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api.h) if you want this to work correctly.
   
   Are you able to build these changes locally to test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org