You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/17 23:05:16 UTC
[GitHub] [incubator-nuttx] ptka opened a new pull request #5535: sim: Enable Rust suppport for hello_rust application.
ptka opened a new pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535
## Summary
Enable compilation of Rust based hello_rust application in 'apps'.
## Impact
nothing as it's new
## Testing
Simulation on MacBook Air M1 with Monterey 12.2.1 using rustc rustc 1.58.1 (stable) via Homebrew.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535#discussion_r809841013
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -95,13 +98,15 @@ endif
NM = $(CROSSDEV)nm
OBJCOPY = $(CROSSDEV)objcopy
OBJDUMP = $(CROSSDEV)objdump
+RUSTC = rustc
Review comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535#discussion_r809767638
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -95,13 +98,15 @@ endif
NM = $(CROSSDEV)nm
OBJCOPY = $(CROSSDEV)objcopy
OBJDUMP = $(CROSSDEV)objdump
+RUSTC = rustc
Review comment:
should we add $(CROSSDEV) too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535#issuecomment-1044661778
@ptka do you port rust runtime to NuttX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535#issuecomment-1044661778
@ptka have you ported the rust runtime to NuttX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535#discussion_r809781263
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -95,13 +98,15 @@ endif
NM = $(CROSSDEV)nm
OBJCOPY = $(CROSSDEV)objcopy
OBJDUMP = $(CROSSDEV)objdump
+RUSTC = rustc
Review comment:
No, that is not needed as rustc by default is a cross compiler for all supported targets. The target is selected via command line option —target and not via different executables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5535: sim: Enable Rust suppport for hello_rust application.
Posted by GitBox <gi...@apache.org>.
ptka commented on a change in pull request #5535:
URL: https://github.com/apache/incubator-nuttx/pull/5535#discussion_r809781263
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -95,13 +98,15 @@ endif
NM = $(CROSSDEV)nm
OBJCOPY = $(CROSSDEV)objcopy
OBJDUMP = $(CROSSDEV)objdump
+RUSTC = rustc
Review comment:
No, that is not needed as rustc by default is a cross compiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org