You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2015/12/01 02:41:02 UTC

[GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...

Github user vrozov commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#issuecomment-160819654
  
    There are few issues that need to be addressed before merging the pull request
    
    * Usage of underscore to separate module namespace is questionable and needs to be discussed. How case when an application has a module "m" with operator "o" and also an operator "m_o" will be handled? All these edge cases must be covered by unit tests
    * Code style violations in the newly introduced code must be fixed.
    * Please review usage of System.out and Logger.info
    * Commented code is present in newly introduced files
    * Missing Java doc
    * Missing unit tests for public methods
    * Inconsistent naming of unit test classes
    
    
    
     
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---